vba query

Johnsmith999

New Member
Joined
Dec 27, 2018
Messages
3
I use the following formula to extract postcodes from addresses and it works perfectly.

TRIM(RIGHT(SUBSTITUTE(A2,"",REPT(" ",10)),20))<o:p></o:p>

However, when I insert the same formula in a vba loop, it does not allow me to execute. REPT is highlighted and the dialogue box says "Compile error: Sub or Function not defined"

Does anyone have a solution? the macro I have written is pasted below:

Sub tob_report()


Dim r As Integer


r = 2


Do Until Cells(r, 1) = ""


Columns(2).Select


Selection.Insert Shift:=xlToRight, CopyOrigin:=xlFormatFromLeftOrAbove


Cells(1, 2).Select


ActiveCell.Value = "Postcode"


Cells(2, 2).Select


ActiveCell.Value = Application.WorksheetFunction.Trim(Right(Substitute(Cells(2, 1), "", Rept("", 10)), 20))


r = i + 1


Loop


End Sub
 

Fluff

MrExcel MVP, Moderator
Joined
Jun 12, 2014
Messages
32,270
Office Version
365
Platform
Windows
How about
Code:
Sub JohnSmith999()
   Columns(2).Insert xlToRight
   Range("B1").Value = "Postcode"
   With Range("B2", Range("A" & Rows.Count).End(xlUp).Offset(, 1))
      .Value = Evaluate(Replace("If({1},TRIM(RIGHT(SUBSTITUTE(@,"""",REPT("" "",10)),20)))", "@", .Offset(, -1).Address))
   End With
End Sub
Although I think that there is something wrong with the formula you posted.
 

Forum statistics

Threads
1,082,130
Messages
5,363,333
Members
400,726
Latest member
Shahzad Taimoor

Some videos you may like

This Week's Hot Topics

  • populate from drop list with multiple tables
    Hi All, i have a drop list that displays data, what i want is when i select one of those from the list to populate text from different tables on...
  • Find list of words from sheet2 in sheet1 before a comma and extract text vba
    Hi Friends, Trying to find the solution on my task. But did not find suitable one to the need. Here is my query and sample file with details...
  • Dynamic Formula entry - VBA code sought
    Hello, really hope one of you experts can help with this - i've spent hours on this and getting no-where. .I have a set of data (more rows than...
  • Listbox Header
    Have a named range called "AccidentsHeader" Within my code I have: [CODE]Private Sub CommandButton1_Click() ListBox1.RowSource =...
  • Complex Heat Map using conditional formatting
    Good day excel world. I have a concern. Below link have a list of countries that carries each country unique data. [URL...
  • Conditional formatting
    Hi good morning, hope you can help me please, I have cells P4:P54 and if this cell is equal to 1 then i want row O to say "Fully Utilised" and to...
Top