VBA to replace parts of text strings according to a conversion table

Hermac

New Member
Joined
Sep 5, 2016
Messages
5
Office Version
  1. 365
Platform
  1. Windows
Hello,
I'm reasonably trained in VBA code but I can't get this one to work.
ToTrim is a long range wit too long strings that I want to shorten.
It contains 19 reappearing substrings (some with a * wildcard) that I want to cut out and replace by some much shorter string or nothing at all.
ReplacTab is a 2-columntable M1:N19 with the annoying substrings in the left column and the replacementes in the right. Looks like this :
1617092125056.png

So why does the code below give me the finger? No error messages either.
Thank you very much for any suggestion!

VBA Code:
Sub Replacer()
Dim c As Range, ToTrim As Range, ReplacTab As Range
Set ToTrim = Sheets("Replac").[J2:J1000]
Set ReplacTab = ActiveWorkbook.Sheets("VasteData").[M1:N19]
For Each c In ReplacTab.Columns(1)
        ToTrim.Replace What:=c.Value, Replacement:=c.Offset(0, 1).Value, LookAt:=xlPart, SearchOrder:=xlByColumns, MatchCase _
        :=False, SearchFormat:=False, ReplaceFormat:=False, FormulaVersion:=xlReplaceFormula2
Next c
End Sub
Gratefully,
Herman Van Noten
 

Attachments

  • 1617091999669.png
    1617091999669.png
    23.1 KB · Views: 6
Last edited by a moderator:

Excel Facts

Copy PDF to Excel
Select data in PDF. Paste to Microsoft Word. Copy from Word and paste to Excel.

Peter_SSs

MrExcel MVP, Moderator
Joined
May 28, 2005
Messages
51,125
Office Version
  1. 365
Platform
  1. Windows
There would be a lot of manual typing to set up that sample data to test. Could we have a small sample of both sheets (including the expected results manually entered or explained) with XL2BB so the we do not have to do all that typing?

BTW, I also suggest ..
  • that you update your Account details (click your user name at the top right of the forum) so helpers always know what Excel version(s) & platform(s) you are using as the best solution often varies by version. (Don’t forget to scroll down & ‘Save’)
  • that you use the forum's code tags when posting code. My signature block below has more information. I have fixed that for you this time.
 
Last edited:

steve the fish

Well-known Member
Joined
Oct 20, 2009
Messages
8,643
Office Version
  1. 365
Platform
  1. Windows
Think you need:

VBA Code:
For Each c In ReplacTab.Columns(1).Cells
 

Peter_SSs

MrExcel MVP, Moderator
Joined
May 28, 2005
Messages
51,125
Office Version
  1. 365
Platform
  1. Windows
From an initial glance at your code it seems that your sheets and ranges are crossed over.

Shouldn't ToTrim be Sheets("VasteData").Range("J2:J1000")

.. and shouldn't ReplacTab be Sheets("Replac").Range("M1:N19")
 

Forum statistics

Threads
1,144,162
Messages
5,722,845
Members
422,460
Latest member
VBA_Noob01

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top