Very basic IF statement is going wrong

[TheRedCardinal]

Hi all,

I have added a prompt for my user to decide if they want to save a file after some processes have been applied to it.

It's a simple message box with a Yes No Option. It worked fine until recently when it started always exiting without opening the Dialog box, even if clicking yes. I stepped through and discovered the Variable was getting a 6 or 7 instead of Yes or No.

So I amended my code:

Answer = MsgBox("Would you like to save your new VAT submission?", vbYesNo + vbQuestion, "Save Submission")
        
            If Answer = vbNo Or Answer = 7 Then
                
               End If
            
            Else
            
                Application.Dialogs(xlDialogSaveAs).Show
              
            End If

But it still doesn't work.

As you can see from the screenshot as I walked through, Answer = 6 but the IF statement is still proceeding to the End If Line, even though the logical test should have failed (I pressed yes on the button, and you can see the Variable = 6)

What very obvious thing am I missing?

 

[ranman256]

vbNo and 7 are the same thing.

use:

If Answer = vbNo  Then 
    'something here
     ' or another IF
     if false then
           beep
     endif
Else
Application.Dialogs(xlDialogSaveAs).Show
End If

 

[Eric W]

I'm surprised that even compiles. You have 2 End If lines for one If. Try something like:

Answer = MsgBox("Would you like to save your new VAT submission?", vbYesNo + vbQuestion, "Save Submission")
        
            If Answer = vbYes
            
                Application.Dialogs(xlDialogSaveAs).Show
              
            End If

 

[TheRedCardinal]

Hi thanks for the answer,

Yes I know that - I wasn't sure why the macro suddenly shifted from being "vbNo" to 7 so I left both in.

What I don't understand is why the IF statement proceeds to the "End If" when neither condition is met?

vbNo and 7 are the same thing.

use:

If Answer = vbNo  Then
    'something here
     ' or another IF
     if false then
           beep
     endif
Else
Application.Dialogs(xlDialogSaveAs).Show
End If

 

[TheRedCardinal]

I'm surprised that even compiles. You have 2 End If lines for one If. Try something like:

Answer = MsgBox("Would you like to save your new VAT submission?", vbYesNo + vbQuestion, "Save Submission")
       
            If Answer = vbYes
           
                Application.Dialogs(xlDialogSaveAs).Show
             
            End If

Hi - I flipped it around to do it your way and it seems to be working now.

The extra End If turned out to be a trailing one from earlier in the code, so I've tidied that up.

I'm still not sure I understand why mine didn't work though (or rather suddenly stopped working) but I have a solution now which is the important bit!