What is wrong with this Do Until Loop? (simple)

skendzie

New Member
Joined
Oct 22, 2014
Messages
6
Thanks in advance for the time. I'm trying to set a Do Until loop and after the range sets, VBA just skips the loop. I want a macro that hides all "0" value columns. What's actually in the loop can be wrong as well, but I just want to know why VBA skips the loop.

My logic is that the range is E120. The loop should start at E120, offset, go to E121 and loop UNTIL E143. I don't get it :(

Code:
    Dim rng As Range    
    Dim col As Long
    
    
    Set rng = Range("E120")
    
    Do Until rng = Range("E143")
    col = rng
    If col = "0" Then hiderng.EntireRow.Hidden = True
            rng = rng.Offset(1, 0)
            Set rng = ActiveCell
        
    Loop
 

mikerickson

MrExcel MVP
Joined
Jan 15, 2007
Messages
22,802
Code:
Set rng=ActiveCell
is your undoing. Get rid of it.

You are also going to have problems with the condition

Code:
Do Until rng = Range("E143")
That line is testing if the value in rng is the same as the value in Range("E143")

I suspect that you want
Code:
Do Until rng.Address = Range("E143").address
 
Last edited:

skendzie

New Member
Joined
Oct 22, 2014
Messages
6
Thanks for the reply! I've never heard of the .address. Got to keep studying!
 

Forum statistics

Threads
1,082,334
Messages
5,364,681
Members
400,810
Latest member
elbashka

Some videos you may like

This Week's Hot Topics

  • populate from drop list with multiple tables
    Hi All, i have a drop list that displays data, what i want is when i select one of those from the list to populate text from different tables on...
  • Find list of words from sheet2 in sheet1 before a comma and extract text vba
    Hi Friends, Trying to find the solution on my task. But did not find suitable one to the need. Here is my query and sample file with details...
  • Dynamic Formula entry - VBA code sought
    Hello, really hope one of you experts can help with this - i've spent hours on this and getting no-where. .I have a set of data (more rows than...
  • Listbox Header
    Have a named range called "AccidentsHeader" Within my code I have: [CODE]Private Sub CommandButton1_Click() ListBox1.RowSource =...
  • Complex Heat Map using conditional formatting
    Good day excel world. I have a concern. Below link have a list of countries that carries each country unique data. [URL...
  • Conditional formatting
    Hi good morning, hope you can help me please, I have cells P4:P54 and if this cell is equal to 1 then i want row O to say "Fully Utilised" and to...
Top