why is this code hiding all rows in range?

[orsm6]

hi - when i step through this code i found it hides all the rows in column a4:a50 that have nothing in them (they contain formulas, but cell is blank) but when i call the code as part of another macro it hides every row in a4:a50 regardless if it has values.

every row in that range has a formula, but if a4:50 is blank then the rest of the columns are blank too.

Sub hiderows()
Worksheets("Layout").Activate

Dim c As Range
Rows("4:50").EntireRow.Hidden = False
        'rehide the blanks
            For Each c In Range("a4:a50")
                If c.Value = "" Then
                    c.EntireRow.Hidden = True
                Else
                    'do nothing, can resinstate the command below, but not required
                    c.EntireRow.Hidden = False
            End If
            Next
End Sub

 

[orsm6]

i think the simplest way because of the way i have the values in A is to have a helper column

 

[ardykav]

I had the same issue with that code a while back, i found that rather than having A result in "" have a helper column that results in a 1 instead and

If c.Value = 1 Then

 

[orsm6]

hmmmm nope, still hides every row.... frustrating.

 

[orsm6]

I had the same issue with that code a while back, i found that rather than having A result in "" have a helper column that results in a 1 instead and

If c.Value = 1 Then

oh yeah i think because i left it in quotes!!.... let me try that

 

[orsm6]

h

I had the same issue with that code a while back, i found that rather than having A result in "" have a helper column that results in a 1 instead and

If c.Value = 1 Then

mmm nope didnt work lol

 

[ardykav]

But have you changed the range Values to where the helper cells are and not column A?

 

[ardykav]

Lets say column F is the helper column

Sub hiderows()
Worksheets("Layout").Activate

Dim c As Range
Rows("4:50").EntireRow.Hidden = False
        'rehide the blanks
            For Each c In Range("f4:f50")
                If c.Value = 1 Then
                    c.EntireRow.Hidden = True
                Else
                    'do nothing, can resinstate the command below, but not required
                    c.EntireRow.Hidden = False
            End If
            Next
End Sub

 

[orsm6]

Lets say column F is the helper column

Sub hiderows()
Worksheets("Layout").Activate

Dim c As Range
Rows("4:50").EntireRow.Hidden = False
        'rehide the blanks
            For Each c In Range("f4:f50")
                If c.Value = 1 Then
                    c.EntireRow.Hidden = True
                Else
                    'do nothing, can resinstate the command below, but not required
                    c.EntireRow.Hidden = False
            End If
            Next
End Sub

i tried it like that.... still hides every row between 4 and 50. in column z is the helper. i have had to use a formula there though to know which is blank and not? so it says if(A5="",1,2)

 

[Michael M]

Maybe this way

Sub hiderows()
Worksheets("Layout").Activate
Dim c As Long
Rows("4:50").EntireRow.Hidden = False
For c = 4 To 50
    If Len(Range("A" & c)) = 0 Then Rows(c).EntireRow.Hidden = True
Next c
End Sub