VBA Looping pulling from web

[jamescooper]

Hello trying to get this to loop:

Sub WebData_2()


    Dim lastRow     As Long
    Dim x           As Long
    Dim urls        As Variant
    Dim Prices      As Variant


'Create sheet


    lastRow = Sheets("7th Aug 2019").Range("H" & Rows.Count).End(xlUp).Row
    urls = Sheets("7th Aug 2019").Range("H11:H" & lastRow).Value


    For x = LBound(urls) To UBound(urls)
        Prices = getprices(urls(x, 1))
        Sheets("7th Aug 2019").Cells(Sheets("7th Aug 2019").Rows.Count, 1).End(xlUp).Offset(1).Resize(UBound(Prices), 17).Value2 = Prices
    Next x
    
End Sub


Private Function getprices(ByVal URL As String) As Variant


    Dim source As Object
    Dim http As New XMLHTTP60, html As New HTMLDocument
      
    With http
        .Open "GET", URL, False
        .send
        html.body.innerHTML = .responseText
    End With


Sheets("7th Aug 2019").Range("F5").Value2 = html.querySelector(".price-details--wrapper .value").innerText
Sheets("7th Aug 2019").Range("G5").Value2 = html.querySelector(".price-per-quantity-weight .value").innerText


End Function

Any ideas please?

 

[jamescooper]

That is almost there now! Thanks! So now it is putting it all in the same column.

So:

    ret(2) = html.querySelector(".price-per-quantity-weight .value").innerText

This bit needs to go in the column adjacent to ret(1).

So column F, i.e. 6 has ret(1), column G, i.e. 7 has ret(2).

Does that make sense?

Thanks a lot learning lots here!

 

[Domenic]

In that case, the first one should do what you want...

[COLOR=#333333]...Resize(, UBound(Prices)).Value2 = Prices[/COLOR]

Did you try it?

 

[jamescooper]

Fantastic - this worked, thanks a lot!

Sub Get_Prices()
    
    Dim lastRow     As Long
    Dim x           As Long
    Dim urls        As Variant
    Dim Prices      As Variant


'Create sheet


    lastRow = Sheets("7th Aug 2019").Range("H" & Rows.Count).End(xlUp).Row
    urls = Sheets("7th Aug 2019").Range("H11:H" & lastRow).Value


    For x = LBound(urls) To UBound(urls)
        Prices = getprices(urls(x, 1))
    Sheets("7th Aug 2019").Cells(Sheets("7th Aug 2019").Rows.Count, 6).End(xlUp).Offset(1).Resize(, UBound(Prices)).Value2 = Prices
    Next x
    
End Sub


Private Function getprices(ByVal URL As String) As Variant


    Dim source As Object
    Dim http As New XMLHTTP60, html As New HTMLDocument
    Dim ret(1 To 2) As String
    
    With http
        .Open "GET", URL, False
        .send
        html.body.innerHTML = .responseText
    End With
    
    ret(1) = html.querySelector(".price-details--wrapper .value").innerText
    ret(2) = html.querySelector(".price-per-quantity-weight .value").innerText
 
getprices = ret


End Function

 

[Domenic]

That's great to hear, cheers!

 

[jamescooper]

Ok So I wish for this code to do something else:

Ignore and skip to the next if a ret(1) or ret(2) if the URL webpage pulls cannot find anything?

Many thanks.

Sub Get_Prices()
    
    Dim lastRow     As Long
    Dim x           As Long
    Dim urls        As Variant
    Dim Prices      As Variant


'Create sheet


    lastRow = Sheets("7th Aug 2019").Range("H" & Rows.Count).End(xlUp).Row
    urls = Sheets("7th Aug 2019").Range("H11:H" & lastRow).Value


    For x = LBound(urls) To UBound(urls)
        Prices = getprices(urls(x, 1))
    Sheets("7th Aug 2019").Cells(Sheets("7th Aug 2019").Rows.Count, 6).End(xlUp).Offset(1).Resize(, UBound(Prices)).Value2 = Prices
    Next x
    
End Sub


Private Function getprices(ByVal URL As String) As Variant


    Dim source As Object
    Dim http As New XMLHTTP60, html As New HTMLDocument
    Dim ret(1 To 2) As String
    
    With http
        .Open "GET", URL, False
        .send
        html.body.innerHTML = .responseText
    End With
    
    ret(1) = html.querySelector(".price-details--wrapper .value").innerText
    ret(2) = html.querySelector(".price-per-quantity-weight .value").innerText
 
getprices = ret


End Function