Exiting a nested for cycle

[Lavina]

Hello guys,

I sometimes have for loops nested in for loops, but once i find my answer id like all of the loops to exit, not just the current one. My current code looks like:

For Each item1 In fulllist1
    For Each item2 In fullList2
        If item2.Text = "hit" Then
            done = True
            Exit For
        End If
    Next
    If done Then Exit For
Next

Is there a better approach to do it?

 

[offthelip]

you can put them all in a subroutine and use exit sub, this is what I do for multiple loops. You do need to declare variables at the module level though!

 

[Lavina]

I try to use global's as the last last resort, but that could indeed work, nice idea thank you!

 

[Norie]

Are the 2 loops/list connected?

 

[MoshiM]

Hello guys,

I sometimes have for loops nested in for loops, but once i find my answer id like all of the loops to exit, not just the current one. My current code looks like:

For Each item1 In fulllist1
    For Each item2 In fullList2
        If item2.Text = "hit" Then
            done = True
            Exit For
        End If
    Next
    If done Then Exit For
Next

Is there a better approach to do it?

Have you tried using goto ?

 

[Lavina]

Have you tried using goto ?

This will require an overhaul of my code, but it should work, i will attempt to implement it!

 

[Lavina]

Are the 2 loops/list connected?

Sorry not sure what you mean by that, but let's imagine i'm browsing through a 2d array that has random numbers inside and i want to exit as soon as even a single copy of the number i'm looking for is found

 

[Eric Golf]

Hi,

Untested but could you set a boolean variable e.g. bExitLoop to False, then set it to True just before exiting the inner loop, then in outer loop check the value of bExitLoop and if True, exit the outer loop?

Hope this helps,

Eric

 

[Fluff]

Whilst it's very much down to personal preference, I tend to do it the same way you have.
I avoid using GoTo wherever possible.

 

[Lavina]

Hey Eric, thats exactly what i have! But I'm afraid when expanding i will run into problems