My macro not working

[ghrek]

Hi

I have the following macro and wondered what ive done wrong as its not moving data when there is data with word "fare" in column E.

Sub MoveData()
Dim ws As Worksheet
Dim lr As Long, i As Long

Application.ScreenUpdating = False

Set ws = Worksheets("Sheet1") 'Data Sheet
lr = ws.Cells(Rows.Count, "E").End(xlUp).Row

For i = 1 To lr
If UCase(ws.Cells(i, "E").Value) = "Fare" Then
ws.Range("E" & i & ":AS" & i).Cut ws.Range("G" & i)
End If
Next i
Application.ScreenUpdating = True
End Sub

Any ideas?

 

[Joe4]

UCASE converts all entries to UPPER case. So it can never equal "Fare".
Try:

[COLOR=#333333]If UCase(ws.Cells(i, "E").Value) = "[/COLOR][COLOR=#ff0000]FARE[/COLOR][COLOR=#333333]" Then[/COLOR]

 

[MARK858]

As Joe4 has pointed out the reason your code isn't working is that Fare needed to be all capitals but also you don't need the End If as you are only doing a single test so it can all go on the one line i.e.

Sub MoveData()
    Dim ws As Worksheet
    Dim lr As Long, i As Long

    Application.ScreenUpdating = False

    Set ws = Worksheets("Sheet1")                'Data Sheet
    lr = ws.Cells(Rows.Count, "E").End(xlUp).Row

    For i = 1 To lr
        If UCase(ws.Cells(i, "E").Value) = "FARE" Then ws.Range("E" & i & ":AS" & i).Cut ws.Range("G" & i)
    Next i
    Application.ScreenUpdating = True
End Sub

 

[ghrek]

Brilliant many thanks