Filter, copy and paste into another sheet

Mykiej23

New Member
Joined
Jun 2, 2016
Messages
22
Hi,
I've been creating a macro to filter on column N in the Raw Data tab and then copy and paste columns A-J into the Report Log at the bottom. It works, except theres currently one result with Check in Column N but it is copy and pasting this in twice. Any idea why?

Code:
Sub filter()Application.ScreenUpdating = False
Dim x As Range
Dim rng As Range
Dim last As Long
Dim sht As String
Dim lastRow As String


'specify sheet name in which the data is stored
sht = "Raw Data"


'change filter column in the following code
last = Sheets(sht).Cells(Rows.Count, "N").End(xlUp).Row
Set rng = Sheets(sht).Range("A2:I" & last)


Sheets(sht).Range("N1:N" & last).AdvancedFilter Action:=xlFilterCopy, CopyToRange:=Range("AA1"), Unique:=True


For Each x In Range([AA2], Cells(Rows.Count, "AA").End(xlUp))
With rng
.AutoFilter
.AutoFilter Field:=14, Criteria1:="Check"
.SpecialCells(xlCellTypeVisible).Copy


    With Sheets("Report Log")
    lastRow = .Range("B" & .Rows.Count).End(xlUp).Offset(1).Row
    .Cells(lastRow, "B").PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, _
                SkipBlanks:=False, Transpose:=False


End With
End With
Next
End Sub

Any help would be appreciated.
 

Excel Facts

Ambidextrous Undo
Undo last command with Ctrl+Z or Alt+Backspace. If you use the Undo icon in the QAT, open the drop-down arrow to undo up to 100 steps.
Try removing the lines in red
Code:
Sub filter()
Application.ScreenUpdating = False
Dim x As Range
Dim rng As Range
Dim last As Long
Dim sht As String
Dim lastRow As String


'specify sheet name in which the data is stored
sht = "Raw Data"


'change filter column in the following code
last = Sheets(sht).Cells(Rows.Count, "N").End(xlUp).Row
Set rng = Sheets(sht).Range("A2:I" & last)


[COLOR=#ff0000]Sheets(sht).Range("N1:N" & last).AdvancedFilter Action:=xlFilterCopy, CopyToRange:=Range("AA1"), Unique:=True


For Each x In Range([AA2], Cells(Rows.Count, "AA").End(xlUp))[/COLOR]
With rng
.AutoFilter
.AutoFilter Field:=14, Criteria1:="Check"
.SpecialCells(xlCellTypeVisible).Copy


    With Sheets("Report Log")
    lastRow = .Range("B" & .Rows.Count).End(xlUp).Offset(1).Row
    .Cells(lastRow, "B").PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, _
                SkipBlanks:=False, Transpose:=False


End With
End With
[COLOR=#ff0000]Next[/COLOR]
End Sub
 
Upvote 0
Try removing the lines in red
Code:
Sub filter()
Application.ScreenUpdating = False
Dim x As Range
Dim rng As Range
Dim last As Long
Dim sht As String
Dim lastRow As String


'specify sheet name in which the data is stored
sht = "Raw Data"


'change filter column in the following code
last = Sheets(sht).Cells(Rows.Count, "N").End(xlUp).Row
Set rng = Sheets(sht).Range("A2:I" & last)


[COLOR=#ff0000]Sheets(sht).Range("N1:N" & last).AdvancedFilter Action:=xlFilterCopy, CopyToRange:=Range("AA1"), Unique:=True


For Each x In Range([AA2], Cells(Rows.Count, "AA").End(xlUp))[/COLOR]
With rng
.AutoFilter
.AutoFilter Field:=14, Criteria1:="Check"
.SpecialCells(xlCellTypeVisible).Copy


    With Sheets("Report Log")
    lastRow = .Range("B" & .Rows.Count).End(xlUp).Offset(1).Row
    .Cells(lastRow, "B").PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, _
                SkipBlanks:=False, Transpose:=False


End With
End With
[COLOR=#ff0000]Next[/COLOR]
End Sub


That worked perfectly, thank you so much!
 
Upvote 0
You're welcome & thanks for the feedback
 
Upvote 0

Forum statistics

Threads
1,214,641
Messages
6,120,691
Members
448,978
Latest member
rrauni

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top