VBA nested if

[MartinL]

Hi can I rewite this better?

If Flag = True Then _
            If vCode <> "" Then _
                If lCodeV >= 0 Then _
                    lCodeVTemp = 0
                    
 If Flag = True Then _
            If vCode <> "" Then _
                If lCodeV < 0 Then _
                    lCodeVTemp = lCodeV

why can i not put:

If Flag = True And vCode <> "" and lCodeV >= 0 Then _
      lCodeVTemp = 0
ElseIf Flag = True And vCode <> "" and lCodeV < 0 Then _
      lCodeVTemp = lCodeV
EndIf

I get error message "else without if"

[VoG]

Try removing the continuation characters (_)

If Flag = True And vCode <> "" And lCodeV >= 0 Then
      lCodeVTemp = 0
ElseIf Flag = True And vCode <> "" And lCodeV < 0 Then
      lCodeVTemp = lCodeV
End If

[Colin Legg]

Hi Martin,

You need to lose the line continuation characters highlighted in red:

If Flag = True And vCode <> "" and lCodeV >= 0 Then _
      lCodeVTemp = 0
ElseIf Flag = True And vCode <> "" and lCodeV < 0 Then _
      lCodeVTemp = lCodeV
EndIf

Or, here's another way of writing it:

    If Flag Then
        If vCode <> "" Then
            If lCodeV >= 0 Then
                lCodeVTemp = 0
            Else
                lCodeVTemp = lCodeV
            End If
        End If
    End If

Hope that helps...

[ketsat]

You can also change it to two separate single line IFs

If Flag = True And vCode <> "" and lCodeV >= 0 Then _
      lCodeVTemp = 0
If Flag = True And vCode <> "" and lCodeV < 0 Then _
      lCodeVTemp = lCodeV

[MartinL]

thanks guys