Simple question I think re: Dateserial from inputbox

[braindiesel]

I am trying to test these 4 lines

confirmMonth = InputBox("What month (number) are they starting the lease? (1=January, 12 = December)", "Month Start", Month(Date) + 1)    
confirmYear = InputBox("What year are they starting the lease?", "Year Start", Year(Date))
    
confirmLength = InputBox("What is the length (in months) of the lease? (1=month to month, 12 = annual)", "Length of Lease")
    
MsgBox DateSerial(confirmYear, confirmMonth + confirmLength, 1)

but the year isn't working.

It seems to be adding the confirmmonth to the confirmyear

Your help is appreciated

 

[AlphaFrog]

I am trying to test these 4 lines

confirmMonth = InputBox("What month (number) are they starting the lease? (1=January, 12 = December)", "Month Start", Month(Date) + 1)    
confirmYear = InputBox("What year are they starting the lease?", "Year Start", Year(Date))
    
confirmLength = InputBox("What is the length (in months) of the lease? (1=month to month, 12 = annual)", "Length of Lease")
    
MsgBox DateSerial(confirmYear, confirmMonth + confirmLength, 1)

but the year isn't working.

It seems to be adding the confirmmonth to the confirmyear

Your help is appreciated

This...
confirmMonth + confirmLength
...is concatenating the two strings (not adding the values). So it is creating two or three digit month values which can be multiple years.

Try this...
MsgBox DateSerial(CLng(confirmYear), CLng(confirmMonth) + CLng(confirmLength), 1)

 

[Jonmo1]

Add this to the top

Dim confirmMonth As Integer, confirmYear As Integer, confirmLength As Integer

Otherwise, the Month and Length are considered TEXT strings
And in VBA, the + operator is like concatenate..
So if the month was 4 and the length was 12, it became 412

 

[JoeMo]

I think your problem is that the Inputbox function returns a string not a number.

Try this:

confirmMonth = Val(InputBox("What month (number) are they starting the lease? (1=January, 12 = December)", "Month Start", Month(Date) + 1))
If confirmMonth = 0 Then Exit Sub
confirmYear = Val(InputBox("What year are they starting the lease?", "Year Start", Year(Date)))
If confirmYear = 0 Then Exit Sub
confirmLength = Val(InputBox("What is the length (in months) of the lease? (1=month to month, 12 = annual)", "Length of Lease"))
If confirmLength = 0 Then Exit Sub
MsgBox DateSerial(confirmYear, confirmMonth + confirmLength, 1)

 

[AlphaFrog]

Alternativly, use an Application.Inputbox of Type:=1 which returns numbers and not strings.

confirmMonth = [B]Application[/B].InputBox("What month (number) are they starting the lease? (1=January, 12 = December)", "Month Start", Month(Date) + 1, [B]Type:=1[/B])
confirmYear = [B]Application[/B].InputBox("What year are they starting the lease?", "Year Start", Year(Date), [B]Type:=1[/B])
    
confirmLength = [B]Application[/B].InputBox("What is the length (in months) of the lease? (1=month to month, 12 = annual)", "Length of Lease", [B]Type:=1[/B])
    
MsgBox DateSerial(confirmYear, confirmMonth + confirmLength, 1)

 

[braindiesel]

Wow. thank you all so much.
The Type:=1 didn't work, but the CLng worked perfectly

I will try the other two out of curiosity. Thanks everyone

 

[AlphaFrog]

Wow. thank you all so much.
The Type:=1 didn't work, but the CLng worked perfectly

I will try the other two out of curiosity. Thanks everyone

You're welcome.

With the Type:=1 solution, declare (Dim) the variables as Integer or Long.