Compile error: invalid outside procedure

[dowcraig]

Hi there,
I'm making changes to row A, but am getting an invalid outside procedure, not sure why. Don't even know what it means. It's not even in the same worksheet.

This is my Macro:
' UpcomingClosings Macro
'
'
Range("B4:I100").Select
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Clear
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Add(Range( _
"H4:H100"), xlSortOnCellColor, xlAscending, , xlSortNormal).SortOnValue.Color _
= RGB(255, 255, 255)
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Add Key:=Range _
("H4:H100"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:= _
xlSortNormal
With ActiveWorkbook.Worksheets("Upcoming Closings").Sort
.SetRange Range("B3:I100")
.Header = xlYes
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
End Sub

 

[Norie]

Where's the Sub... part of the code?

 

[RoryA]

You appear to be missing the Sub line at the start:

Sub UpcomingClosings()

 

[dowcraig]

Sorry, this is my macro:
Private Sub Workbook_BeforeSave(Cancel As Boolean)
'
' UpcomingClosings Macro
'
'
Range("B4:I100").Select
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Clear
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Add(Range( _
"H4:H100"), xlSortOnCellColor, xlAscending, , xlSortNormal).SortOnValue.Color _
= RGB(255, 255, 255)
ActiveWorkbook.Worksheets("Upcoming Closings").Sort.SortFields.Add Key:=Range _
("H4:H100"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:= _
xlSortNormal
With ActiveWorkbook.Worksheets("Upcoming Closings").Sort
.SetRange Range("B3:I100")
.Header = xlYes
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
End Sub

 

[dowcraig]

I really have no clue what I'm doing here.

Can I put a macro for each worksheet in their own respective worksheet in Microsoft Visual basic, or does it have to be in "This workbook". If it has to be in "this workbook, how do I put multiple ones?

 

[RoryA]

Each worksheet has its own module - right-click the tab and choose View Code, or double-click the sheet in Project Explorer in the VBEditor.
Do you have anything else in the ThisWorkbook module?

 

[dowcraig]

My Microsoft Virtual Basic has the following tree:
- VBAProject (2009 Sales.xlsm)
- Sheet1 (2009)
- Sheet2 (Upcoming Closings)
- Sheet3 (Outstanding Gifts)
- Sheet4 (Referral Sources)
- Sheet5 (Referrals Out)
- ThisWorkbook
- Modules
- Module1
- Module2
- Module3
- Module4
- Module5
- Module6


Where can I put the Macro from the Upcoming Closings and Outstanding Gifts? Do they go in:
- Sheet2 (Upcoming Closings)
- Sheet3 (Outstanding Gifts)

or do they go in:
- ThisWorkbook

 

[RoryA]

The Workbook_beforesave routine is an event routine and has to go in the thisworkbook module to be triggered when you save the workbook

 

[dowcraig]

But, can I put more than one macro in the ThisWorkbook?

 

[RoryA]

Yes, but the only ones that really belong there are workbook events like BeforeSave