Exit Sub if document is not saved

[tobysmith69]

Hello all,

I am new to this forum, and a complete and utter beginner at VBA. Using guides from various forums on the internet, I have produced the below sub. It prompts a person to Save As the excel spreadsheet they are in, before calling on another sub which attaches the newly saved spreadsheet to an e-mail. This all works absolutely fine, however when prompted to save the document, if they click Cancel and don't save it, it will still carry out the second sub. I want it to exit the sub and not continue if they haven't saved the document, but I can't for the life of me work out how to do this. Any help gratefully received!

Toby

Sub mcrSave()

'Retrieve file name to use for Save
fileSaveName = Application.GetSaveAsFilename( _
fileFilter:="Excel Files (*.xls), *.xls")

'If user specified file name, perform Save and display msgbox
If fileSaveName <> False Then
ActiveWorkbook.SaveAs Filename:=fileSaveName, FileFormat:=xlNormal

End If

Call EmailOrder

End Sub

 

[Kamolga]

Hi and welcome to the forum,

response = MsgBox("Do you want to save and send the file?", vbYesNo)
If response = vbNo Then Exit Sub

[COLOR=#008000]'Code here​ Will run only if user click yes[/COLOR]

 

[AFPathfinder]

if they click Cancel and don't save it, it will still carry out the second sub. I want it to exit the sub and not continue if they haven't saved the document

Toby,
Try moving "Call EmailOrder" inside the If Statement.

Sub mcrSave()

    'Retrieve file name to use for Save
    fileSaveName = Application.GetSaveAsFilename(fileFilter:="Excel Files (*.xls), *.xls")
    
    'If user specified file name, perform Save and display msgbox
    If fileSaveName <> False Then
        ActiveWorkbook.SaveAs Filename:=fileSaveName, FileFormat:=xlNormal
        Call EmailOrder
    End If


End Sub

You can also add "Exit Sub" inside the If statement after the "ActiveWorkbook.SaveAs" line if you need to keep "Call EmailOrder" outside. Hope this helps!

 

[tobysmith69]

Thank you to you both for your help. I have moved Call EmailOrder inside the If statement, and it now works perfectly.