Help with shell command on paths with spaces

[jryan15]

Hi all,

I'm really struggling to workout this shell command on paths with spaces in them.

The code below works with no issue, but as soon as I uncomment the long path with the same set of 20 zip files, I get an error (Error: cannot find archive).

I feel like I've tried an infinite number of versions using multiple quotes and chr(34)'s, but I can seem to get anything to work.

Sub UnZipFiles()
    Dim command As String
       
       
    zip = "C:\Program Files\7-Zip\7z.exe"
       
    Source = "C:\test"
    Destin = "C:\dump"
    
 '   Source = "C:\Users\xxxxx\Documents\More Sad Attempts at VB\LEC stuff\test"
 '   Destin = "C:\Users\xxxxx\Documents\More Sad Attempts at VB\LEC stuff\dump"
    
    command = """" & zip & """" & " e " & Source & " -o" & Destin
       
    Shell "cmd /k " & (command), vbNormalFocus
End Sub

 

[Haluk]

I am not sure, but can you try this;

Command = """" & zip & """" & " e '" & Source & "' -o '" & Destin & "'"

 

[John_w]

You need quotes around the executable and its two arguments. Multiple quotes in strings are hard to read and I usually prefer calling a helper function to apply the quotes.

    ':
    ':

    command = Q(zip) & " e " & Q(Source) & " -o " & Q(Destin)
    
    Shell "cmd /k " & command, vbNormalFocus
End Sub

Private Function Q(text As String) As String
     Q = Chr(34) & text & Chr(34)
End Function

 

[jryan15]

SOLVED! Re: Help with shell command on paths with spaces

Got it fixed! Had to find a way to wrap the entire phrase in quotes.


"C:\Program Files\7-Zip\7z.exe" e C:\test -oC:\dump

need to become:

""C:\Program Files\7-Zip\7z.exe" e C:\test -oC:\dump"


Here is the code for what worked:

Sub UnZipFiles()
    Dim command As String
       
    'path to 7zip program
    zip = "C:\Program Files\7-Zip\7z.exe"
    
    'path of source and destination folders
    Source = "C:\Users\XXXXXX\Documents\More Sad Attempts at VB\LEC stuff\C137-2678_XXXX-1\test"
    Destin = "C:\Users\XXXXXX\Documents\More Sad Attempts at VB\LEC stuff\C137-2678_XXXX-1\dump"
 
    'command string
    command = """""" & zip & """" & " e " & """" & Source & """" & " -o" & """" & Destin & """" & """"
       
    'shell operation
    Shell "cmd /k " & command, vbNormalFocus

End Sub