I need help with this code to modify the data into a table using Userform for VBA Excel (I want to do the range unlimited instead to do C7:C80000

MohamedAmin

New Member
Joined
May 17, 2023
Messages
21
Office Version
  1. 2021
Platform
  1. Windows
Repc.png
Rep.png

VBA Code:
ThisWorkbook.Activate
'=============================================

Dim X As Long
Dim xx As Long
Dim fwr As Integer
Dim fwo As Integer

mer = " Data Error : "
mtk = " Data Duplicate Error : "

If Me.CbInvStore.MatchFound = False Then: MsgBox mer & vbCrLf & vbCrLf & " Please select the type of invoice ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

If Me.CbCustomerName.MatchFound = False Then: MsgBox mer & vbCrLf & vbCrLf & "  Please select the name of client", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

'If Me.TbInvNo = "" Then: MsgBox mer & vbCrLf & vbCrLf & " Please enter the invoice number ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

If Me.TbDate = "" Then: MsgBox mer & vbCrLf & vbCrLf & "  Please enter the Invoice date  ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

If Me.ListBox1.ListCount <= 1 Then: MsgBox mer & vbCrLf & vbCrLf & " You have not added item to be saved ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

'====check date entry '==
dtval = Val(Format(Me.TbDate, "0"))
mindt = 40909
maxdt = Val(Format(Date + 1, "0"))
If dtval < mindt Then: MsgBox mer & vbCrLf & vbCrLf & "Sorry .. Program does not accept date before the year 2012 ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub
If dtval > maxdt Then: MsgBox mer & vbCrLf & vbCrLf & "Sorry .. Program does not accept a future date ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub
'=========================

  fwr = Application.WorksheetFunction.CountIfs(Rep.Range("C7:C80000"), Me.CbInvStore.Value, Rep.Range("F7:F80000"), Me.TbInvNo.Value)     'I need to change it to lastrow 
  fwrc = Application.WorksheetFunction.CountIfs(Repc.Range("B9:B30000"), Me.CbInvStore.Value, Repc.Range("D9:D30000"), Me.TbInvNo.Value)     'I need to change it to lastrow 
  fwo = Me.ListBox1.ListCount - 1 ' no of items
 '==========================================================

 If fwr < 1 Then:  MsgBox mer & vbCrLf & vbCrLf & "Please enter the invoice number ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub
 If fwrs < 1 Then:  MsgBox mer & vbCrLf & vbCrLf & "Please enter the invoice number ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

 If fwrc < 1 Then:  MsgBox mer & vbCrLf & vbCrLf & " Invoice number not found in the statement of the client's account", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub
  If fwrc > 1 Then:  MsgBox mtk & vbCrLf & vbCrLf & " Duplicate invoice number " & fwrc & "  Once ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub
 If fwo < 1 Then:  MsgBox mer & vbCrLf & vbCrLf & " There are no items to be adjusted ", vbCritical + vbMsgBoxLeft, "Inventory Program ": Exit Sub

confir = MsgBox("Would you like to save the change...  ?", vbOKCancel, "Inventory Program  ")
If confir = vbCancel Then: Exit Sub

Application.ScreenUpdating = False

On Error GoTo 1

With Rep
.Select
.Unprotect ("0000")
 AutoFilterMode = False
.Range("$C$6:$Z$6").AutoFilter field:=2, Criteria1:=Me.CbInvStore.Value
.Range("$C$6:$Z$6").AutoFilter field:=5, Criteria1:=Me.TbInvNo.Value

 lastrow = .Range("F80000").End(xlUp).Row + 1        'I need to change it to lastrow 
.Range("$C$6:$Z$6").AutoFilter

If fwo = fwr Then
   X = lastrow - fwr
   xx = lastrow - 1
ElseIf fwo > fwr Then
    d = fwo - fwr
    X = lastrow - fwr
   xx = lastrow + d - 1
   .Range(Cells(lastrow, "c"), Cells(xx, "c")).Select
   Selection.EntireRow.Insert , CopyOrigin:=xlFormatFromLeftOrAbove
ElseIf fwo < fwr Then
   X = lastrow - fwr
   xx = X + fwo - 1
   Y = xx + 1
   z = lastrow - 1
   .Range(Cells(Y, "c"), Cells(z, "c")).Select
   Selection.EntireRow.Delete
Else
     MsgBox "There is somthing wrong. will be exit ", vbCritical, "Inventory Program  "
End If

 Me.TbDate.Text = Format(Me.TbDate.Text, "dd/mm/yyyy")

.Range(Rep.Cells(X, "B"), Rep.Cells(xx, "B")) = Me.comDepartment.Value   'Department
.Range(Rep.Cells(X, "C"), Rep.Cells(xx, "C")) = Me.CbInvStore.Value   'inv_store
.Range(Rep.Cells(X, "D"), Rep.Cells(xx, "D")) = Me.CbPayment.Value  'pay_method
.Range(Rep.Cells(X, "E"), Rep.Cells(xx, "E")) = Me.Lbl_typ.Caption   'inv_type
.Range(Rep.Cells(X, "F"), Rep.Cells(xx, "F")) = Format(Me.TbInvNo.Value, "00000")  'inv no
.Range(Rep.Cells(X, "G"), Rep.Cells(xx, "G")) = Me.TbDate.Value    'date
.Range(Rep.Cells(X, "H"), Rep.Cells(xx, "H")) = Me.CbCustomerName.Value   'customer
.Cells(X, "I") = Me.TbTotalNetPrice.Value   'balance
.Range(Rep.Cells(X, "T"), Rep.Cells(xx, "T")) = Users.Range("aw6").Value   'users

 If Me.CbInvStore.Value = Data.Range("BF7") Then
        .Cells(X, "Z") = Me.TbTotalNetPrice.Value   'balance
 End If

If Me.CbInvStore.Value = Data.Range("BF8") Then
        .Cells(X, "Y") = Me.TbTotalNetPrice.Value   'balance
 End If


Inv.Unprotect ("0000")
Inv.Range("B9:M500").ClearContents
Inv.Range("B8:M" & 8 + fwo).Cells.Value = Me.ListBox1.List
.Range(.Cells(X, "J"), .Cells(xx, "S")) = Inv.Range("B9:K" & 8 + fwo).Value 'all product
.Range(.Cells(X, "W"), .Cells(xx, "X")) = Inv.Range("L9:M" & 8 + fwo).Value 'all product

.Protect Password:=("0000")
End With

'=========================================================================================

With Repc
  .Select
 .Unprotect ("8521")
   AutoFilterMode = False
 .Range("$B$8:$P$8").AutoFilter field:=1, Criteria1:=Me.CbInvStore.Value
 .Range("$B$8:$P$8").AutoFilter field:=3, Criteria1:=Me.TbInvNo.Value
 
  ss = .Range("f30000").End(xlUp).Row       'I need to change it to lastrow 
 .Range("$d$8:$r$8").AutoFilter

 .Cells(ss, "F").Value = Me.CbCustomerName.Value  'customer
 .Cells(ss, "B").Value = Me.CbInvStore.Value  'inv store
 .Cells(ss, "C").Value = Me.TbDate.Value  'date
 .Cells(ss, "K").Value = Me.CbPayment.Value
 '.Cells(ss, "E").Value = inv.Range("e3").Value ' id
 .Cells(ss, "O").Value = Me.CbMrName.Value  'mr
 .Cells(ss, "P").Value = Users.Range("aw6").Value  'user

'CASE RETURN=====================
If Me.CbInvStore.Value = Data.Range("BF9") Or Me.CbInvStore.Value = Data.Range("BF10") Then
.Cells(ss, "I") = Me.TbTotalNetPrice.Value    'balance repcus
Else
.Cells(ss, "G") = Me.TbTotalNetPrice.Value   'balance repcus
End If

If Me.CbPayment.Value = "Cash" Then
.Cells(ss, "H") = Me.TbTotalNetPrice.Value   'balance repcus
Else
End If

.Protect Password:=("8521")
End With


'=========end case return ======
'======CASE PRMOTION=============
If Me.CbInvStore.Value = Data.Range("BF11") Or Me.CbInvStore.Value = Data.Range("BF12") Then

With Repc
.Unprotect ("8521")
.Range(.Cells(ss, "G"), .Cells(ss, "P")).ClearContents
.Cells(ss, "F") = Me.CbCustomerName.Value & " " & Data.[bb3]  'customer repcus offer
.Protect Password:=("0000")
 End With
End If
'======end case prmotion======

'======== recall inv ========
 Me.Btn_invs.Value = Me.CbInvStore.Value
 Me.Btn_invn.Value = Me.TbInvNo.Value
 CmdRecallInv_Click
'============================
sort_rep_customer

If Me.CreditBox.Value = True Then   'CbPayment = "Credit"
  Call Credit
End If

confir = MsgBox(" Change Successfuly Saved", vbInformation, "Inventory Progarm")
Main.Select
1 Application.ScreenUpdating = True
 

Excel Facts

Ambidextrous Undo
Undo last command with Ctrl+Z or Alt+Backspace. If you use the Undo icon in the QAT, open the drop-down arrow to undo up to 100 steps.
Hi. I'm not 100% certain I understand what it is that you're trying to do, but if you're trying to make the range of data dynamic in size (rather than limited to C80000), you can do something like:

VBA Code:
LastRow = .Cells(.Rows.Count, "F").End(xlUp).Row + 1

See if that works.
 
Upvote 0
Separately, for future reference, you'd be better off not being the first one to reply to your own thread. A lot of people who answer questions in this forum will look at the list of "Unanswered questions" and work from there. If you've responded to your own thread, that essentially takes you off that list, and so you run the risk of no one seeing your question! Which is why it's best to put as much information as you can in the original post.

You're welcome to ping me, but there is no guarantee that I will see it, or have time to see it, or even that I will know the answer!

It used to be the case (I think) that you would be re-added to the Unanswered Questions list if you simply wrote the word "Bump" in a post, but not sure if that's still the case.
 
Upvote 0
Hi. I'm not 100% certain I understand what it is that you're trying to do, but if you're trying to make the range of data dynamic in size (rather than limited to C80000), you can do something like:

VBA Code:
LastRow = .Cells(.Rows.Count, "F").End(xlUp).Row + 1

See if that works.
How about this one?
VBA Code:
fwr = Application.WorksheetFunction.CountIfs(Rep.Range("C7:C80000"), Me.CbInvStore.Value, Rep.Range("F7:F80000"), Me.TbInvNo.Value)        'I need to change it to lastrow
fwrc = Application.WorksheetFunction.CountIfs(Repc.Range("B9:B30000"), Me.CbInvStore.Value, Repc.Range("D9:D30000"), Me.TbInvNo.Value)     'I need to change it to lastrow
 
Upvote 0
Well rather than rewrite your code for you, I can explain to you the logic used to work out the last row, and then you will know how to do it yourself. Here is a great resource: Find Last Row Or Last Column With VBA Code (Best Way)

Basically, it finds the Row number by going to the the last row in the worksheet (Rep.Rows.Count) for a given column ("F"). Then, as though you were doing it manually, if you imagine you're at the last row of a column, and you pressed CTRL + Up Arrow Key on your keyboard, it will take you to the first populated cell Excel finds. That is effectively what this code is doing. As for your question, once you know the last row for F (which appears to be the same as the last row for C), you could rewrite this line as:

VBA Code:
fwr = Application.WorksheetFunction.CountIfs(Rep.Range("C7:C" & LastRow), Me.CbInvStore.Value, Rep.Range("F7:F" & LastRow), Me.TbInvNo.Value)

Does this makes sense?
 
Upvote 0

Forum statistics

Threads
1,215,406
Messages
6,124,720
Members
449,184
Latest member
COrmerod

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top