Invalid procedure call or argument in Function

[Philosophaie]

This error message in line vpp:

Invalid procedure call or argument

Function fn1(ByVal a, ByVal i, ByVal e, ByVal N, ByVal w, ByVal ta)
    Pi = Application.WorksheetFunction.Pi
    mhu = 398600    
    vpp = (mhu / Math.Sqr(mhu * a * (1 - e ^ 2))) * (-Math.Sin(ta * Pi / 180))
    fn1 = 2 * vpp
End Function

 

[Jonmo1]

I get that error if the Sqr function recieves a negative number.

so if this part evaluates to a negative number, you will get that error
mhu * a * (1 - e ^ 2)

 

[Philosophaie]

Function KeplerianToRandV(ByVal a, ByVal i, ByVal e1, ByVal N, ByVal w, ByVal ta)
Pi = Application.WorksheetFunction.Pi
mhu = 398600
If e1 <> 1 And e1 * Math.Cos(ta * Pi / 180) <> -1 Then
vpp = (mhu / Math.Sqr(mhu * a * (1 - e1 ^ 2))) * (-Math.Sin(ta * Pi / 180))
Else
MsgBox("Divides by Zero")
End If
End Function

Still getting a Procedural error.

 

[Jonmo1]

Can you post your call to the function, what values are being provided for each variable (a i e1 N w ta)

 

[shg]

Maybe ...

Function fn1(a As Double, e As Double, ta As Double) As Variant
    Const pi        As Double = 3.14159265358979
    Const D2R       As Double = pi / 180#
    Const mhu       As Double = 398600#
    If e <= 1 Then
        fn1 = -2 * mhu / Sqr(mhu * a * (1 - e ^ 2)) * Sin(ta * D2R)
    Else
        fn1 = CVErr(xlErrDiv0)
    End If
End Function

You're passing several arguments that aren't used.

 

[Philosophaie]

All can be traced to a viable number:

e = .Cells(3, 3)
i = .Cells(3, 4)
N = .Cells(3, 5)
w = .Cells(3, 6)
a = (rp0 + ra0) / 2
rv0 = KeplerianToRandV(a, e, i, N, w, 180)

 

[shg]

That's fine, but the function doesn't use them.

 

[Philosophaie]

e1=

0.00149

<tbody>
</tbody>

ta=

132.5478 a= 6794 <tbody> </tbody>

<tbody>
</tbody>

rv0 = fn1(a, e1, ta)

 

[shg]

I can see that they appear in the function's signature; my point is, they are not used by the function:

vpp = (mhu / Math.Sqr(mhu * a * (1 - e1 ^ 2))) * (-Math.Sin(ta * Pi / 180))

Where do N, i, and w appear in that expression?

 

[Jonmo1]

You seem to have e and i reversed...

In the function you posted, it's declared as
Function fn1(ByVal a, ByVal i, ByVal e, ByVal N, ByVal w, ByVal ta)
i comes before e

But in the call to the function, you put
rv0 = fn1(a, e, i, N, w, 180)
e comes before i



If this isn't it..
Please....
Post the values (values, not cell refernces) of ALL the variables
And the actual code that is trying to USE the function.