MWSC18

New Member
Joined
Jan 25, 2018
Messages
6
Office Version
  1. 2016
Platform
  1. Windows
Hello,

Developing a code in Excel VBA for work (code at the end of this post) and I am running into the following error a few times in the code:

Run-time error ‘438’:
Object doesn’t support this property or method


This code (full code posted below at end) is executed in one workbook, opens another, does some actions, and then repeats two more times for two other workbooks. The error seems to happen when I interact with any other workbook I open as part of the code. For example, the error is first encountered when executing the bolded line below:

Rich (BB code):
Dim WBName As String
WBName = "S:\Sales_Order_Tracking\Backlog\Sales Order Log - Peter.xlsm"
Workbooks.Open Filename:=WBName, ReadOnly:=True

The 438 error is thrown, I click “Ok,” the code is immediately exited/cancelled, but the file WBName does in fact open in read-only mode. Then, I immediately run it again while the file WBName is open, and it does NOT give me a 438 error when executing that line. However, it then has a problem with the following line, giving the same 438 error:

Rich (BB code):
Set cRangePK = SOLPK.Range("A2", lastcell)

I also noticed in the line above Set cRangePK when it determines which cell address lastcell is, it’s grabbing that from the TBCData sheet and NOT the PKData sheet. It’s like the program does not even know that Sales Order Log – Peter exists or is open and isn’t interacting with it…

I am beyond confused because I use a nearly identical code in another project and it has worked flawlessly for years. The above code also worked in a simple proof of concept in some test files for this current project.
Test code below - works as intended:

Code:
Sub Workbook_Open()

Application.ScreenUpdating = False
Application.Calculation = xlCalculationManual
Application.Cursor = xlWait
Application.DisplayStatusBar = True
Application.StatusBar = "Importing Medical Data..."

Dim medmaster, backlog As Workbook
Dim meddatash, backlogdatash As Worksheet
Dim cRangeMed As Range
Dim lastcell As String

Set backlog = Workbooks("BacklogPullTest.xlsm")
Set backlogdatash = backlog.Sheets("AllDataList")

'Opens the Medical Data File
Dim WBName As String

WBName = "S:\TESTING\A\B\BacklogMasterTest.xlsm"
Workbooks.Open Filename:=WBName, ReadOnly:=True

'Clears any existing data on Backlog Data Sheet
backlogdatash.Cells.ClearContents

Set medmaster = Workbooks("BacklogMasterTest.xlsm")

'Copies data from MedMaster to Backlog
Set meddatash = medmaster.Sheets("MedData")
meddatash.Activate
lastcell = Cells(Cells.Find(What:="*", SearchOrder:=xlRows, SearchDirection:=xlPrevious, LookIn:=xlValues).Row, _
 Cells.Find(What:="*", SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, LookIn:=xlValues).Column).Address
Set cRangeMed = Range("A1", lastcell)
backlogdatash.Range("A1", lastcell).Value = cRangeMed.Value

'Closes MedMaster without saving
medmaster.Close (False)

Application.Calculation = xlCalculationAutomatic
Application.Cursor = xlDefault
Application.StatusBar = False
Application.ScreenUpdating = True

backlog.RefreshAll 'Refreshes all sheets and data connections

End Sub

Now in the main project I am seeing problems when really all I did was change names of files and sheets. I’m not sure if there is some property in the Sales Order Log files that is set differently somehow that is causing the problem, but if so, I wouldn’t even know what to look for to know what that might be.

Thanks for any insight or resolutions!

Full code for current project:

Code:
Sub Update()

Application.ScreenUpdating = False
Application.Calculation = xlCalculationManual
Application.Cursor = xlWait
Application.DisplayStatusBar = True
Application.StatusBar = "Importing Sales Order Log data..."

Dim SOLPK, SOLGF, SOLSS, TBC As Workbook
Dim PKData, TBCData As Worksheet
Dim cRangePK As Range
Dim WBName, lastcell As String

Set TBC = Workbooks("Total Backlog Compile.xlsm")
Set TBCData = TBC.Sheets("Backlog Data")

'Clears any existing data on Backlog Data Sheet
TBCData.Activate
If TBCData.Range("BD2") = "" Then GoTo NoData
lastcell = Cells(Cells.Find(What:="*", SearchOrder:=xlRows, SearchDirection:=xlPrevious, LookIn:=xlValues).Row, _
 Cells.Find(What:="*", SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, LookIn:=xlValues).Column).Address
TBCData.Range("A2", lastcell).ClearContents
'-----------------------------------------------------------------------------------------------------------------
NoData:
'Opens Sales Order Log - Peter
WBName = "S:\Sales_Order_Tracking\Backlog\Sales Order Log - Peter.xlsm"
Workbooks.Open Filename:=WBName, ReadOnly:=True
Set SOLPK = Workbooks("Sales Order Log - Peter.xlsm")

'Copies data from Sales Order Log - Peter to Total Backlog Compile
Set PKData = SOLPK.Sheets("Backlog_Template")

PKData.Activate
lastcell = Cells(Cells.Find(What:="*", SearchOrder:=xlRows, SearchDirection:=xlPrevious, LookIn:=xlValues).Row, _
 Cells.Find(What:="*", SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, LookIn:=xlValues).Column).Address
Set cRangePK = SOLPK.Range("A2", lastcell)
TBCData.Range("A2", lastcell).Value = cRangePK.Value

'Closes Sales Order Log - Peter without saving
SOLPK.Close (False)

Application.Calculation = xlCalculationAutomatic
Application.Cursor = xlDefault
Application.StatusBar = False
Application.ScreenUpdating = True

End Sub
 

Excel Facts

How to calculate loan payments in Excel?
Use the PMT function: =PMT(5%/12,60,-25000) is for a $25,000 loan, 5% annual interest, 60 month loan.
With the following line of code . . .

VBA Code:
Set cRangePK = SOLPK.Range("A2", lastcell)

. . . you're missing the sheet reference. By the way, with the following declaration...

VBA Code:
Dim SOLPK, SOLGF, SOLSS, TBC As Workbook

. . . only TBC is declared as Workbook, your other variables are declared as Variant. To declare each one as Workbook...

VBA Code:
Dim SOLPK As Workbook, SOLGF As Workbook, SOLSS As Workbook, TBC As Workbook

And the same thing for your other similar lines of declarations.

Hope this helps!
 
Upvote 0
I tried this
Rich (BB code):
Dim WBName As String
WBName = "S:\Sales_Order_Tracking\Backlog\Sales Order Log - Peter.xlsm"
Workbooks.Open Filename:=WBName, ReadOnly:=True

and did not have any issues

You might try this variation to see if you can get more info about the problem
VBA Code:
    Dim WB As Workbook
    Dim WBName As String
    
    WBName = "S:\Sales_Order_Tracking\Backlog\Sales Order Log - Peter.xlsm"

    On Error Resume Next
    Set WB = Workbooks.Open(Filename:=WBName, ReadOnly:=True)
    On Error GoTo 0
    
    If WB Is Nothing Then
        MsgBox "There was a problem opening the workbook"
        Exit Sub
    End If
 
Upvote 0

Forum statistics

Threads
1,215,419
Messages
6,124,796
Members
449,189
Latest member
kristinh

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top