Best Vba practice

[julhs]

I have numerous modules that have the SAME section of code in them to carry out the same task.

Before I take what I’m doing any further, just want to clarify “Best Vba” practice.

Is it best/better to keep those sections of code in EACH individual module or have them in a separate module and “Call” them as and when required?
Having them in a separate module, then calling them when required seems to me to be somewhat similar to using,
“GoTo line?:” (Spaghetti code).
What is the advice?

 

[My Aswer Is This]

I would do it something like this:

Sub Hello()
MsgBox "Hello Julhs"
End Sub
Sub Goodbye()
MsgBox "Goodbye Julhs "
End Sub
Sub Both()
Cells(1, 1).Value = "1"
Call Hello
Cells(2, 1).Value = "2"
Call Goodbye
End Sub

 

[dmt32]

I have numerous modules that have the SAME section of code in them to carry out the same task.

Something considered good coding practice is do not repeat yourself or DRY for short.

If you have code in each module that is doing the same thing then create either a common code or a Function if need it to return a value & call it as required.

general explanation here but there are plenty of examples you can search

Excel VBA Function Tutorial: Return, Call, Examples

What is a Function? A function is a piece of code that performs a specific task and returns a result. Functions are mostly used to carry out repetitive tasks such as formatting data for output, perfor

www.guru99.com

Dave

 

[julhs]

Thank you both for your advice.

Dave, found the link you sent particularly helpful.

 

[dmt32]

Thank you both for your advice.

Dave, found the link you sent particularly helpful.

most welcome glad we could help & appreciate your feedback

Dave