Call a Sub Multiple Times Due to Error Handler

[wsnyder]

Hi all,

Is it ok to call my sub multiple times as I am doing below?
Is there a better way to make sure the sub executes?

Thanks,
-w

Sub foo()


    Dim olApp As Object
    
    Call ShutdownExcelEvironment
    
    On Error Resume Next
    Set olApp = CreateObject("Outlook.Application")
    
    If Not olApp Is Nothing Then
        'Object exists continue
    Else
        MsgBox "The Outlook Application does not exist"
        Debug.Print "reached"
        Call RestoreExcelEvironment
        Exit Sub
    End If
    
    Debug.Print "ta-da!"
    Call RestoreExcelEvironment
    
End Sub



Public Sub ShutdownExcelEvironment()
    With Application
      .Calculation = xlCalculationManual
      .ScreenUpdating = False
      .DisplayStatusBar = False
      .EnableEvents = False
      .DisplayAlerts = False
    End With
End Sub


Public Sub RestoreExcelEvironment()
    With Application
      .Calculation = xlCalculationAutomatic
      .ScreenUpdating = True
      .DisplayStatusBar = True
      .EnableEvents = True
      .DisplayAlerts = True
    End With
End Sub

 

[frabulator]

I personally do not see anything wrong with what you are doing. I would do it a bit differently, but that mainly boils down to preferences.

    If Not olApp Is Nothing Then
       Debug.Print "ta-da!"
        'Object exists continue
    Else
        MsgBox "The Outlook Application does not exist"
        Debug.Print "reached"
    End If
 
    RestoreExcelEvironment

Doing the above would achieve the same outcome, if I am reading it correctly.

--EDIT--
Something that I would add is the inclusion of 'On Error goto 0'.
When you use 'On Error Resume Next' you are basically telling Excel, "Yeah, I know this is going to fail. I want it to. Just skip it." Once you are finished with the 'errored' part, you need to add in 'On Error goto 0'. That will reset Excel back to its default error catching functions.

 

[wsnyder]

Thanks, frabulator,

Appreciate your thoughts/insights.

Thanks,
-w