Can you check my sort code please

[ipbr21054]

Hi,
I have this code shown below.

Its supposed to sort the data list using column D
When i use the command button nothing happens / changes/
I dont even get an error message.

Do you see ?
Thanks

Private Sub SortListA_Z_Click()
    Dim x As Long
    
    Application.ScreenUpdating = False
    
    With Sheets("KEY CODE LIST")
        If .AutoFilterMode Then .AutoFilterMode = False
        x = .Cells(.Rows.Count, 1).End(xlUp).Row
        
        .Range("D2:F" & x).Sort Key1:=Range("D2"), Order1:=xlAscending, Header:=xlGuess
    
    End With
                      
    ActiveWorkbook.Save
    
    Application.ScreenUpdating = True
    Sheets("KEY CODE LIST").Range("A1").Select
End Sub

 

[DanteAmor]

x = .Cells(.Rows.Count, 1).End(xlUp).Row

You must use a column with data, in your code you are using column 1, in your image column 1 is empty, then you can use D

x = .Cells(.Rows.Count, "D").End(xlUp).Row

 

[JoeMo]

If you don't have anything in col A, then x = 1 and you are sorting the range D1:F2 only. With headers in row 1 that leaves only one row to sort so it appears nothing is happening. If you want to sort col D then change this:

x = .Cells(.Rows.Count, 1).End(xlUp).Row
to this:

x = .Cells(.Rows.Count, 4).End(xlUp).Row

 

[ipbr21054]

Many thanks.
I did change the code from 1 to 4 before i posted but received a syntax error.

I also changed 1 to D which also failed.

Changing it to "D" like Dante advised worked.

I forget ""

 

[ipbr21054]

Hi,
Ive noticed for some reason that once i run the sort code a blank row is shown at row 2
The value A1 should be first ?

See screen shot

 

[ipbr21054]

Here is the worksheet.

https://www.theremotedoctor.co.uk/forums/KEY CODES.xlsm

At the bottom of the list type A1 in the cell
When codes runs it sorts fine.
Change Z1 and sort again.

Now delete Z1 & save.

Now sort A-Z
The cell you deleted Z1 from goes to the top