Please advise on my IF code

[ipbr21054]

Below is part of my full code.
It should print an invoice then ask if it printed ok.
If YES then continue to do the part in Red.

BUT if NO then print again & then do the part in RED

Currently both the print options work BUT the part in Red does nothing

    With ActiveSheet
      'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE NOW PRINTED
      MsgBox "1st Print"
    End With
      answer = MsgBox("INVOICE HAS NOW BEEN SAVED" & vbNewLine & vbNewLine & "DID THE INVOICE PRINT OK FOR YOU ?", vbInformation + vbYesNo, "INVOICE PRINT OK MESSAGE")
    If answer = vbNo Then
      'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE PRINTED AGAIN IF FIRST PRINT WAS POOR
      MsgBox "2nd Print"
      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G46:G50").ClearContents
      Range("L18").ClearContents
      Range("G13").ClearContents
      Range("G13").Select
      ActiveWorkbook.Save
    End If
       
    End With

    End Sub

 

[MARK858]

I am then told i need to add 1 x End With so i add it at the bottom

That is because you have a With ActiveSheet at the start of your code that does nothing and runs the whole length of your code (see my previous comments about your With / End With's)

Remove both the lines in red

Private Sub Print_Invoice_Click()
    Dim answer As Integer
    Dim rng As Range
    Dim cell As Range
    Dim MyFile As String
    Dim findString As String
    Dim sPath As String, strFileName As String
    Dim srcWS As Worksheet, destWS As Worksheet
    Set srcWS = ActiveWorkbook.Worksheets("INV")
    Set destWS = ActiveWorkbook.Worksheets("DATABASE")
   
    With ActiveSheet
    If Range("G13") = "" Then
      MsgBox "NO NAME SELECTED IN THE CUSTOMER DETAILS SECTION", vbCritical, "NO CUSTOMER SELECTED MESSAGE"
      Range("G13").Select 'CHECKING IF CUSTOMER IS SELECTED
    Exit Sub
    End If
 
    If Range("L18") = "" Then
      MsgBox ("PLEASE SELECT A PAYMENT TYPE "), vbCritical, "PAYMENT TYPE WAS NOT SELECTED"
      Range("L18").Select 'CHECKING IF PAYMENT TYPE HAS BEEN SELECTED
    Exit Sub
    End If
       
    strFileName = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR COPY INVOICES\" & Range("L4").Value & ".pdf"
    If Dir(strFileName) <> vbNullString Then
      MsgBox "INVOICE " & Range("L4").Value & " WAS NOT SAVED AS IT ALLREADY EXISTS" & vbNewLine & vbNewLine & "PLEASE CHECK FILE IN FOLDER THAT WILL NOW OPEN.", vbCritical + vbOKOnly, "INVOICE NOT SAVED MESSAGE"
      VBA.Shell "explorer.exe /select, " & "" & strFileName & "", vbNormalFocus 'DUPLICATE INVOICE FOUND
    Exit Sub
    End If
   
    strFileName = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR COPY INVOICES\" & Range("L4").Value & ".pdf"
    With ActiveSheet
      .ExportAsFixedFormat Type:=xlTypePDF, fileName:=strFileName, Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas:=False
    End With 'CURRENT INVOICE IS NOW SAVED
   
    With ActiveSheet
      .ExportAsFixedFormat Type:=xlTypePDF, fileName:=strFileName, Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas:=False
    End With 'CURRENT INVOICE IS NOW SAVED
   
    With Sheets("DATABASE")
      Worksheets("DATABASE").Activate
    End With
   
    Set rng = ActiveSheet.Columns("A:A")
      findString = Worksheets("INV").Range("G13").Value
    Set cell = rng.Find(What:=findString, LookIn:=xlFormulas, _
      LookAt:=xlWhole, MatchCase:=False) ' CUSTOMER FOUND IN COLUMN A
   
    If cell Is Nothing Then
      MsgBox "NO CUSTOMER WAS FOUND"
    Else
    With Sheets("DATABASE")
      cell.Select
      ActiveCell.Offset(0, 15).Select ' CUSTOMERS CELL IN COLUMN P NOW SELECTED
    End With
    End If
   
    If Len(ActiveCell.Value) <> 0 Then
      ValueInInvoiceCell.Show 'MESSAGE SHOWN IF CUSTOMERS INVOICE CELL IN COLUMN P HAS A VALUE IN IT

    Exit Sub
    Else
      TransferInvoiceNumber.Show 'NOW ENTER INVOICE NUMBER IN CUSTOMERS CELL IN COLUMN P & NOW HYPERLINKED
    End If
   
    With Sheets("INV")
      Worksheets("INV").Activate
    End With
     
        'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE NOW PRINTED
        MsgBox "1st Print"
 
 
    answer = MsgBox("INVOICE HAS NOW BEEN SAVED" & vbNewLine & vbNewLine & "DID THE INVOICE PRINT OK FOR YOU ?", vbInformation + vbYesNo, "INVOICE PRINT OK MESSAGE")
 
    If answer = vbNo Then
        'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE PRINTED AGAIN IF FIRST PRINT WAS POOR
        MsgBox "2nd Print"
   End If


   Range("L4").Value = Range("L4").Value + 1
   Range("G27:L36").ClearContents
   Range("G46:G50").ClearContents
   Range("L18").ClearContents
   Range("G13").ClearContents
   Range("G13").Select
   ActiveWorkbook.Save
   End With
  
End Sub

 

[ipbr21054]

Lines of code in Red removed but message still shown

 

[MARK858]

I don't get a With / End With missing message with them removed

 

[ipbr21054]

The message i refer to Is duplicate of Dim answer As Long

 

[MARK858]

Strange because I can only see one in the code that you have posted or the code I posted (and the one that I can see is an Integer btw)

 

[ipbr21054]

It wasnt in the code i supplied & i mention in post 20 So i leave it out.
It was left out & code does whats its supposed to do

So should i leave it out as there isnt another ?

 

[MARK858]

There should be one

Dim answer As Integer

that's it, nothing else starting Dim answer