VBA If statement w/multiple conditions

[bobkap]

I'm trying to perfect a simple macro that calculates profit margin based on 3 different conditions: 1) I have cost and desired margin but missing price; 2) I have price and desired margin but missing cost; 3) I have cost and price but missing margin calculation.

I've listed my code below but if my condition is met at either the first of second scenario I'm not sure how to end the routine there. Any help would be most appreciated.

Sub GMBK()
'
' GMBK Macro
'

cost = Range("b4").Value
Price = Range("c4").Value
margin = Range("d4").Value


If IsEmpty(Cells(4, 4)) Then
netp = Price - cost
margin = (netp / Price)
Cells(4, 4).NumberFormat = "0.0%"
Cells(4, 4) = margin

Else
If IsEmpty(Cells(4, 2)) Then
cost = Price / (1 - margin)


Else
If Price = cost / (1 - margin) Then
Cells(4, 3) = Price
End If
End If
End If
'
'
End Sub

 

[Joe4]

I've listed my code below but if my condition is met at either the first of second scenario I'm not sure how to end the routine there. Any help would be most appreciated.

You should not have to change anything. Since you have each succeeding IF condition buried in the ELSE of the previous IF, it should exit once the first one is met.
So your code should be fine as it is.

If you try stepping through your code, you should be able to see this.

 

[bobkap]

Thanks very much. I actually did step through it before I did that post and every time it bombed out with this message: Run-time error '13': Type Mismatch. And when I clicked on debug it highlighted this line of code towards in the last if statement area: If Price = cost / (1 - margin) Then.

 

[Joe4]

What are your values fro Price, Cost, and Margin?

 

[bobkap]

Thanks but I think I figured it out. I did not have an "isempty" test for my middle scenario. I corrected that and it works fine now.

 

[Joe4]

Thanks but I think I figured it out. I did not have an "isempty" test for my middle scenario. I corrected that and it works fine now.

If that is the case, "Debug" should have highlighted that line, and not the one you mentioned in your previous post.

Note that if you want to check for an empty cell, you can just use:

If Cells(4, 4) = "" Then

 

[bobkap]

Nice! I did not know that. THANKS again!

 

[Joe4]

You are welcome.