Arrgh Arrays

[daverunt]

Hi all,

I have some basic code to create an array of filenames in a folder. All good.
I remove the timestamps and extensions from the files, which leaves small groups of files with the exact same name.

eg:

Dave
Dave
Dave
Fred
Fred
Fred
John
John
John
etc

These are all added to the array.
However I need each name to appear only once in the array.

At what point do I check whether the name already exists in the array?
Can it be done before adding the name to the array?
Or does it have to be done after it has been preserved?

Sub Create_Array()

Dim MyFile As String
Dim Counter As Long

Dim DirectoryListArray() As String
ReDim DirectoryListArray(50)


MyFile = Dir$("C:\junk\357536080015052\*.res")
Do While MyFile <> ""

    ResFileName = (Left(MyFile, Len(MyFile) - 22)) ' This means there are several files with the same name once the timestamps are removed.
    
    DirectoryListArray(Counter) = ResFileName
       
    MyFile = Dir$
    Counter = Counter + 1
    
Loop

ReDim Preserve DirectoryListArray(Counter - 1)


'Print the array content to check
For Counter = 0 To UBound(DirectoryListArray)
 
    Debug.Print DirectoryListArray(Counter)
Next Counter
End Sub

 

[HaHoBe]

Hi daverunt,

try changing

Do While MyFile <> ""
    ResFileName = (Left(MyFile, Len(MyFile) - 22)) ' This means there are several files with the same name once the timestamps are removed.    
    DirectoryListArray(Counter) = ResFileName       
    MyFile = Dir$
    Counter = Counter + 1    
Loop

to

Do While MyFile <> ""
  ResFileName = (Left(MyFile, Len(MyFile) - 22)) ' This means there are several files with the same name once the timestamps are removed.
  If IsError(Application.Match(ResFileName, DirectoryListArray, 0)) Then
    DirectoryListArray(Counter) = ResFileName
    Counter = Counter + 1
  End If
  MyFile = Dir()
Loop

Ciao,
Holger

 

[Fluff]

Another option is to use a dictionary

Sub Create_Array()

Dim MyFile As String
Dim Counter As Long

Dim DirectoryListArray As Object
Set DirectoryListArray = CreateObject("scripting.dictionary")


MyFile = Dir$("C:\junk\357536080015052\*.res")
Do While MyFile <> ""

    ResFileName = (Left(MyFile, Len(MyFile) - 22)) ' This means there are several files with the same name once the timestamps are removed.
    
    DirectoryListArray(ResFileName) = Empty
       
    MyFile = Dir$
    Counter = Counter + 1
    
Loop



'Print the array content to check
For Counter = 0 To DirectoryListArray.Count - 1
 
    Debug.Print DirectoryListArray()(Counter)
Next Counter
End Sub

 

[daverunt]

Awesome.
Cheers Holger

 

[daverunt]

Cheers Fluff.

will try that one Monday.

Thanks

 

[Fluff]

Ok

 

[daverunt]

Another option is to use a dictionary

Sub Create_Array()

Dim MyFile As String
Dim Counter As Long

Dim DirectoryListArray As Object
Set DirectoryListArray = CreateObject("scripting.dictionary")


MyFile = Dir$("C:\junk\357536080015052\*.res")
Do While MyFile <> ""

    ResFileName = (Left(MyFile, Len(MyFile) - 22)) ' This means there are several files with the same name once the timestamps are removed.
   
    DirectoryListArray(ResFileName) = Empty
      
    MyFile = Dir$
    Counter = Counter + 1
   
Loop



'Print the array content to check
For Counter = 0 To DirectoryListArray.Count - 1
 
    Debug.Print DirectoryListArray()(Counter)
Next Counter
End Sub

Hi Fluff,

this errors on the debug.print line - wrong num arguments/invalid property assignment so I used DirectoryListArray(Counter)

However there's nothing then printing to the window.
I don't see where it is adding the unique file name to the array?

 

[Fluff]

Oops, missed a bit, it should be

    Debug.Print DirectoryListArray.Keys()(Counter)

 

[daverunt]

Oops, missed a bit, it should be

    Debug.Print DirectoryListArray.Keys()(Counter)

Yeas that works great thanks

 

[Fluff]

You're welcome & thanks for the feedback.