Before Save Event

[mysterious-dr-x]

It is in ThisWorkbook as it should be, however it doesn't work, what have I done wrong....again....?

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    Call Remove_Duplicates
    Call ReOrder
End Sub

 

[Peter_SSs]

It is possible that your code is not working because 'Events' are disabled. In the VBA window, ensure the Immediate Window is visible (View|Immediate Window) and then on a new line in the Immediate Window, type

Application.EnableEvents=True and press Enter

Now go back to your workbook and try saving again.

 

[mysterious-dr-x]

It is possible that your code is not working because 'Events' are disabled.

Tried with no success, any other thoughts?

 

[shg]

Have you enabled macros? Set a breakpoint in the first line of the code?

 

[mysterious-dr-x]

Have you enabled macros? Set a breakpoint in the first line of the code?

Yes, & have just tried, no luck.

It seems to be dissatisfied with this part;

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)

 

[shg]

In what way is this dissatisfaction made manifest?

 

[Peter_SSs]

Have you enabled macros? Set a breakpoint in the first line of the code?

Yes, & have just tried, no luck.

Is that a Yes to both shg's questions? If you add the blue line of code and save the workbook do you get the message box?

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    MsgBox "BeforeSave code has fired"
    Call Remove_Duplicates
    Call ReOrder
End Sub

 

[mysterious-dr-x]

do you get the message box?

No, I do not

 

[Peter_SSs]

No, I do not

OK, not trying to be rude here but just thinking aloud. You say that you have checked and..
- 'Events' are not disabled
- Macros are enabled
- Workbook_BeforeSave code is in the ThisWorkbook module
- Workbook_BeforeSave event is not firing

What explanations are there?
a) Events are disabled
b) Macros are not enabled
c) The Workbook_BeforeSave code is in the wrong ThisWorkbook module.
d) (Other possibilities?)

 

[Peter_SSs]

What if you take a fresh workbook and save it. Then, with no other code, put this in its ThisWorkbook module then try to save the workbook again. Do you get the message box?

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    MsgBox "BeforeSave code has fired"
End Sub