BeforeSave Event not saving...

[jfgoodhew1]

Hi Guys,

I wrote a beforesave event in the Workbook module in Excel 2010 VBA, and the save fails. I've simplified it, commented out my entire block and written a lovely simple one (shown here), and it still fails. Any help much appreciated!

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
'First checks state of boolean 
'Prevents save twice behaviour in VBA
'Boolean set to true on Workbook_Open event

Cancel = True

If ThisWorkbook.EnableBeforeSave = True Then
    ThisWorkbook.SaveAs "2014-09-08-INV.xlsm"
    MsgBox ThisWorkbook.Saved & " on save"
Else
    MsgBox "ThisWorkbook.EnableBeforeSave is " & ThisWorkbook.EnableBeforeSave
End If

If ThisWorkbook.Saved = False Then MsgBox "There was an error saving the spreadsheet."
    
End Sub

Notes:
Every time I click Save I get False as ThisWorkbook.Saved and "There was an error saving the spreadsheet."
Save As does the same, and I tried putting code into a BeforeClose event to save it - no joy.

Any clues why this might be? What have I screwed up?? ... Been staring at this for ages.

 

[jfgoodhew1]

OK So I realised what changed: the boolean test for save/not save. ***
Before that, I was using Application.EnableEvents - which I read was bad.
I wrapped only the save line in Application.EnableEvents = False followed by True after the save.
Presto, it works.

Very interested to know why it fails without though!

*** By the way, that boolean should have a line immediately above Else, and it's defined as Public EnableBeforeSave As Boolean in the ThisWorkbook module.

ThisWorkbook.EnableBeforeSave = False