Code is out of order. Running 3 times to get final total. Need help correcting.

greegan

Well-known Member
Joined
Nov 18, 2009
Messages
644
Office Version
  1. 365
Platform
  1. Windows
I've got the following code...
Code:
Sub Calc_Fed_AnnualIncome()
    Application.ScreenUpdating = False
    Application.DisplayAlerts = False
Set TheRange = Range("A1:B35").SpecialCells(xlCellTypeConstants, xlTextValues)
Wage = Range("B1")
Hours = Range("B2")
PPD = Range("B4")
P = ShowPayPeriod(PPD)
EnterPayPeriod
Dim pCell As Range
For Each pCell In TheRange
  If pCell.Value = "P" Then
    pCell.Offset(0, 1) = P
  End If
Next pCell
Dim asalCell As Range
For Each asalCell In TheRange
  If asalCell.Value = "Annual Salary" Then
    asalCell.Offset(0, 1) = ASal
  End If
Next asalCell
ASal = (Wage * Hours * P)
Dim iCell As Range
For Each iCell In TheRange
  If iCell.Value = "I" Then
    iCell.Offset(0, 1) = I
  End If
Next iCell
'I = ((Wage * Hours * 52) / (P))
I = (ASal / P)
Dim fCell As Range
For Each fCell In TheRange
  If fCell.Value = "F" Then
    fCell.Offset(0, 1) = F
  End If
Next fCell
Dim f2Cell As Range
For Each f2Cell In TheRange
  If f2Cell.Value = "F2" Then
    f2Cell.Offset(0, 1) = F2
  End If
Next f2Cell
Dim u1Cell As Range
For Each u1Cell In TheRange
  If u1Cell.Value = "U1" Then
    u1Cell.Offset(0, 1) = U1
  End If
Next u1Cell

Dim hdCell As Range
For Each hdCell In TheRange
  If hdCell.Value = "HD" Then
    hdCell.Offset(0, 1) = HD
  End If
Next hdCell
Dim f1Cell As Range
For Each f1Cell In TheRange
  If f1Cell.Value = "F1" Then
    f1Cell.Offset(0, 1) = F1
  End If
Next f1Cell
If A < 0 Then
    T = L
Else: T = A
End If
Dim aCell As Range
For Each aCell In TheRange
  If aCell.Value = "A" Then
    aCell.Offset(0, 1) = A
  End If
Next aCell
A = ((P * (I - F - F2 - U1)) - HD - F1)
Dim rCell As Range
For Each rCell In TheRange
  If rCell.Value = "R" Then
    rCell.Offset(0, 1) = R
  End If
Next rCell
    Range("B15").Select
    ActiveCell.FormulaR1C1 = "=CaTaxRate(R[-1]C)"
    Range("B15").Select
    Selection.Copy
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    ActiveSheet.Paste
    Application.CutCopyMode = False
R = CaTaxRate(A)
Dim arCell As Range
For Each arCell In TheRange
  If arCell.Value = "AR" Then
    arCell.Offset(0, 1) = AR
  End If
Next arCell
AR = A * R
Dim kCell As Range
For Each kCell In TheRange
  If kCell.Value = "K" Then
    kCell.Offset(0, 1) = K
  End If
Next kCell
K = CaTaxConstant(A)
Dim ftCell As Range
For Each ftCell In TheRange
  If ftCell.Value = "FT" Then
    ftCell.Offset(0, 1) = FT
  End If
Next ftCell
FT = AR - K
 
'Next tcCell
Worksheets("TD1FED").Range("D19") = TC
Dim k1Cell As Range
For Each k1Cell In TheRange
  If k1Cell.Value = "K1" Then
    k1Cell.Offset(0, 1) = K1
  End If
Next k1Cell
K1 = 0.15 * TC
Dim k2Cell As Range
For Each k2Cell In TheRange
  If k2Cell.Value = "K2" Then
    k2Cell.Offset(0, 1) = K2
  End If
Next k2Cell
K2 = (0.15 * (Application.Min(P * C, 2217.6))) + (0.15 * (Application.Min(P * EI, 786.76)))
Dim k3Cell As Range
For Each k3Cell In TheRange
  If k3Cell.Value = "K3" Then
    k3Cell.Offset(0, 1) = K3
  End If
Next k3Cell
Dim k4Cell As Range
For Each k4Cell In TheRange
  If k4Cell.Value = "K4" Then
    k4Cell.Offset(0, 1) = K4
  End If
Next k4Cell
    If (0.15 * A) < (0.15 * 1065) Then
        K4 = (0.15 * A)
    Else
        K4 = (0.15 * 1065)
    End If
Dim t3Cell As Range
Dim T3x1 As Currency
For Each t3Cell In TheRange
  If t3Cell.Value = "T3" Then
    t3Cell.Offset(0, 1) = T3
  End If
Next t3Cell
T3x1 = K1 + K2 + K3 + K4
T3 = FT - T3x1
 
'CPP_Calc
CPPx = 3500
CPPd = 0.0495
Dim cppCell As Range
            C = (I - (CPPx / P)) * CPPd
For Each cppCell In TheRange
  If cppCell.Value = "CPP" Then
    cppCell.Offset(0, 1) = C
  End If
Next cppCell
 
'EmpIns
EIp = 0.0178
            EI = I * EIp ' / P
 
Dim eiCell As Range
For Each eiCell In TheRange
  If eiCell.Value = "EI" Then
    eiCell.Offset(0, 1) = EI
  End If
Next eiCell
Dim LCFCell As Range
For Each LCFCell In TheRange
  If LCFCell.Value = "LCF" Then
    LCFCell.Offset(0, 1) = LCF
  End If
Next LCFCell

   Dim W As Currency
Dim wCell As Range
For Each wCell In TheRange
  If wCell.Value = "Withheld?" Then
    wCell.Offset(0, 1) = W
  End If
Next wCell
    'W = 2000
    If 0.15 * W < 750 Then
        LCF = 0.15 * W
    Else
        LCF = 750
    End If
Dim t1Cell As Range
For Each t1Cell In TheRange
  If t1Cell.Value = "T1" Then
    t1Cell.Offset(0, 1) = T1
  End If
Next t1Cell

AR = A * R
T3 = A * R - (K + K1 + K2 + K3 + K4)
T1 = T3 - LCF
    Application.ScreenUpdating = True
    Application.DisplayAlerts = True
End Sub

In the range A1:A29 I have the following
Code:
Hourly Wage 
Hours Worked 
Wage Earned 
Pay Period Description 
Pay Period 
Annual Salary 
P 
I 
F 
F2 
U1 
HD 
F1 
A 
R 
AR 
K 
FT 
K1 
K2 
K3 
K4 
T3 
Withheld? 
LCF 
T1 
(A27 is blank) 
CPP 
EI


In B1 and B2 I have 27.5 and 80, respectively.
B4 has Biweekly
Practically all of the declarations are Currency...
Code:
Option Base 1 
Option Explicit 
 
Public A As Currency 
Public C As Currency 
Public CPPx As Currency 
Public CPPd As Double 
Public EI As Currency 
Public EIp As Double 
Public EIq As Double 
Public F As Currency 
 
Public F1 As Currency 
 
Public F2 As Currency 
 
Public F3 As Currency 
 
 
Public F4 As Currency 
 
 
Public QPIP As Double 
Public HD As Currency 
Public I As Currency 
Public I1 As Currency 
Public K As Currency 
Public K1 As Currency 
Public K2 As Currency 
 
Public K3 As Currency 
 
Public K4 As Currency 
Public KP As Currency 
Public K1P As Currency 
Public K2P As Currency 
 
Public K3P As Currency 
 
Public K4P As Currency 
Public L As Currency 
Public LCF As Currency 
Public LCP As Currency 
Public P As Variant 
Public R As Double 
Public T As Currency 
Public T1 As Currency 
Public T2 As Currency 
Public T3 As Currency 
Public T3x1 As Currency 
Public T4 As Currency 
Public TC As Currency 
Public TCP As Currency 
Public U1 As Currency 
Public V As Currency 
Public V1 As Currency 
Public V2 As Currency 
Public YTD As Currency 
Public Wage As Currency 
Public Hours As Double 
Public CPP As Currency 
Public RA As Currency 
Public FT As Currency 
Public TheRange As Range 
Public caTC As Currency 
Public ASal As Currency 
Public PPD As String 
Public TD1FED As Currency 
 
Public AR As Currency 
Public W As Currency

There are some custom functions folks here have assisted me with and are called within the above code...
Code:
Function CaTaxRate(Rate) As Double
' Calculates Tax Rates
    Select Case Rate
        Case 0 To 41543.99:         CaTaxRate = 1 * 0.15
        Case 41544 To 83087.99:     CaTaxRate = 1 * 0.22
        Case 83088 To 128799.99:    CaTaxRate = 1 * 0.26
        Case Is >= 128800:          CaTaxRate = 1 * 0.29
    End Select
    
End Function
Function CaTaxConstant(Constant) As Double
' Calculates Tax Constants
    Select Case Constant
        Case 0 To 41543.99:         CaTaxConstant = 1 * 0
        Case 41544 To 83087.99:     CaTaxConstant = 1 * 2908
        Case 83088 To 128799.99:    CaTaxConstant = 1 * 6232
        Case Is >= 128800:          CaTaxConstant = 1 * 10096
    End Select
    
End Function
Function ShowPayPeriod(PayPeriod) As Integer
    Select Case PayPeriod
        Case "Daily":           ShowPayPeriod = 240
        Case "Weekly":          ShowPayPeriod = 52
        Case "Biweekly":        ShowPayPeriod = 26
        Case "Semi-monthly":    ShowPayPeriod = 24
        Case "Monthly":         ShowPayPeriod = 12
        Case "Other 10":        ShowPayPeriod = 10
        Case "Other 13":        ShowPayPeriod = 13
        Case "Other 22":        ShowPayPeriod = 22
        Case "Weekly 53":       ShowPayPeriod = 53
        Case "Biweekly 27":     ShowPayPeriod = 27
    End Select
End Function

If I want the code to fill in column B I have to run the macro more than once. I have spent days trying to figure this out and haven't been able to find my error. If I change something it seems to change the code enough where it doesn't work at all.
Can someone assist me please?
If you need more information, please feel free to ask.



-- g
 

Excel Facts

What does custom number format of ;;; mean?
Three semi-colons will hide the value in the cell. Although most people use white font instead.
Is anyone able to help me with this? Maybe I need to provide more information?

-- g
 
Upvote 0
I might have answered this myself...
Code:
Sub Calc_Fed_AnnualIncomeXXXYYY()
    Application.ScreenUpdating = False
    Application.DisplayAlerts = False
Set TheRange = Range("A1:B35").SpecialCells(xlCellTypeConstants, xlTextValues)
Wage = Range("B1")
Hours = Range("B2")
PPD = Range("B4")
P = ShowPayPeriod(PPD)
EnterPayPeriod
Dim xCell As Range
For Each xCell In TheRange
  If xCell.Value = "P" Then
    xCell.Offset(0, 1) = P
  End If
Next xCell
For Each xCell In TheRange
  If xCell.Value = "Annual Salary" Then
    xCell.Offset(0, 1) = ASal
  End If
ASal = (Wage * Hours * P)
  If xCell.Value = "I" Then
    xCell.Offset(0, 1) = I
  End If
'I = ((Wage * Hours * 52) / (P))
I = (ASal / P)

'F = 17.66
  If xCell.Value = "F" Then
    xCell.Offset(0, 1) = F
  End If
  If xCell.Value = "F2" Then
    xCell.Offset(0, 1) = F2
  End If
  If xCell.Value = "U1" Then
    xCell.Offset(0, 1) = U1
  End If

  If xCell.Value = "HD" Then
    xCell.Offset(0, 1) = HD
  End If
  If xCell.Value = "F1" Then
    xCell.Offset(0, 1) = F1
  End If
If A < 0 Then
    T = L
Else: T = A
End If
  If xCell.Value = "A" Then
    xCell.Offset(0, 1) = A
  End If
A = ((P * (I - F - F2 - U1)) - HD - F1)
  If xCell.Value = "R" Then
    xCell.Offset(0, 1) = R
  End If
    Range("B15").Select
    ActiveCell.FormulaR1C1 = "=CaTaxRate(R[-1]C)"
    Range("B15").Select
    Selection.Copy
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    ActiveSheet.Paste
    Application.CutCopyMode = False
R = CaTaxRate(A)
  If xCell.Value = "AR" Then
    xCell.Offset(0, 1) = AR
  End If
AR = A * R
  If xCell.Value = "K" Then
    xCell.Offset(0, 1) = K
  End If
K = CaTaxConstant(A)
  If xCell.Value = "FT" Then
    xCell.Offset(0, 1) = FT
  End If
FT = AR - K
'Dim tcCell As Range
'For Each tcCell In TheRange
'  If tcCell.Value = "TC" Then
'    tcCell.Offset(0, 1) = TC
'  End If
'Next tcCell
Worksheets("TD1FED").Range("D19") = TC
  If xCell.Value = "K1" Then
    xCell.Offset(0, 1) = K1
  End If
K1 = 0.15 * TC
  If xCell.Value = "K2" Then
    xCell.Offset(0, 1) = K2
  End If
K2 = (0.15 * (Application.Min(P * C, 2217.6))) + (0.15 * (Application.Min(P * EI, 786.76)))
  If xCell.Value = "K3" Then
    xCell.Offset(0, 1) = K3
  End If
  If xCell.Value = "K4" Then
    xCell.Offset(0, 1) = K4
  End If
    If (0.15 * A) < (0.15 * 1065) Then
        K4 = (0.15 * A)
    Else
        K4 = (0.15 * 1065)
    End If
Dim T3x1 As Currency
  If xCell.Value = "T3" Then
    xCell.Offset(0, 1) = T3
  End If
T3x1 = K1 + K2 + K3 + K4
T3 = FT - T3x1
'CPP_Calc
CPPx = 3500
CPPd = 0.0495
'        If A >= 48378.59 Then
'            C = (48378.59 / P - (CPPx / P)) * CPPd
'        Else
            C = (I - (CPPx / P)) * CPPd
'        End If

  If xCell.Value = "CPP" Then
    xCell.Offset(0, 1) = C
  End If
'EmpIns
EIp = 0.0178
'P = Range("B5")
'    A = Range("B6")
'        If A >= 44200 Then
'            EI = 44200 * EIp / P
'        Else
            EI = I * EIp ' / P
'        End If
 
  If xCell.Value = "EI" Then
    xCell.Offset(0, 1) = EI
  End If
  If xCell.Value = "LCF" Then
    xCell.Offset(0, 1) = LCF
  End If

   Dim W As Currency
  If xCell.Value = "Withheld?" Then
    xCell.Offset(0, 1) = W
  End If
    W = 2000
    If 0.15 * W < 750 Then
        LCF = 0.15 * W
    Else
        LCF = 750
    End If
  If xCell.Value = "T1" Then
    xCell.Offset(0, 1) = T1
  End If
 
AR = A * R
T3 = A * R - (K + K1 + K2 + K3 + K4)
T1 = T3 - LCF
Next xCell
    Application.ScreenUpdating = True
    Application.DisplayAlerts = True
End Sub

by removing all of the For...Next statement except the first, it loads the answers into the cells on one click.

I guess I just needed more time to think about it. :)

-- g
 
Upvote 0

Forum statistics

Threads
1,224,602
Messages
6,179,848
Members
452,948
Latest member
UsmanAli786

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top