Code not working

Mel Smith

Well-known Member
Joined
Dec 13, 2005
Messages
1,023
Office Version
  1. 365
Platform
  1. Windows
I'm using the following code to highlight the maximum value in a range but it keeps failing at the "maxVal = cell.Value" line:

VBA Code:
Sub Strike_Rate()
    Dim rng As Range
    Dim cell As Range
    Dim maxVal As Double
  
     Set rng = Range("DI4:DI33") ' Change this to your desired range
  
       maxVal = rng.Cells(1).Value
  
    For Each cell In rng
        If cell.Value > maxVal Then
            maxVal = cell.Value
        End If
    Next cell
  
     For Each cell In rng
        If cell.Value = maxVal Then
            cell.Interior.Color = RGB(255, 255, 0) ' Highlight in red; you can change the color as desired
        End If
    Next cell
End Sub

The maximum value in this case is 120.90.

Can someone point me in the right direction, please?

Mel
 

Excel Facts

Remove leading & trailing spaces
Save as CSV to remove all leading and trailing spaces. It is faster than using TRIM().
I'm using the following code to highlight the maximum value in a range but it keeps failing at the "maxVal = cell.Value" line:

VBA Code:
Sub Strike_Rate()
    Dim rng As Range
    Dim cell As Range
    Dim maxVal As Double
 
     Set rng = Range("DI4:DI33") ' Change this to your desired range
 
       maxVal = rng.Cells(1).Value
 
    For Each cell In rng
        If cell.Value > maxVal Then
            maxVal = cell.Value
        End If
    Next cell
 
     For Each cell In rng
        If cell.Value = maxVal Then
            cell.Interior.Color = RGB(255, 255, 0) ' Highlight in red; you can change the color as desired
        End If
    Next cell
End Sub

The maximum value in this case is 120.90.

Can someone point me in the right direction, please?

Mel


This code working fine on my side
 
Upvote 0
See if this change fixes it:

Rich (BB code):
    For Each cell In rng
        If cell.Value > maxVal And IsNumeric(cell.Value) Then
            maxVal = cell.Value
        End If
    Next cell
 
Upvote 0
Solution

Forum statistics

Threads
1,215,097
Messages
6,123,077
Members
449,094
Latest member
mystic19

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top