Combobox Error on Change event

[hstaubyn]

Hi,

I have a combobox that is misbehaving. It has a change event that should change a label on the same userform depending on the combobox value that is selected. To do this I use the worksheet function 'vlookup', but whenever the code runs, I get a run-time error 1004. The problem seems to be in the use of vlookup, but this method works on another combobox (referencing text) on the same userform. My code is below:

Private Sub CboJobNo_Change()
    LblProjName.Caption = Application.WorksheetFunction.VLookup(CboJobNo.Value, Range("Job_List"), 2, False)
End Sub

'LblProjName' is the label being changed
'CboJobNo' is the combobox being changed

'Job_List' is a named range in the worksheet of two columns with job numbers in the first (stored as numbers) and corresponding job names in the second (stored as text).

The error message is as follows:

"Unable to get the VLookup property of the WorksheetFunction class"


Does anyone know where I am going wrong? Any help would be greatly appreciated.

 

[Ruddles]

Replace CboJobNo.Value with CLng(CboJobNo.Value) in the VLookup and see if that works.

 

[hstaubyn]

Ruddles,

no joy I'm afraid, still doesn't work. Thanks for the suggestion though.

 

[RoryA]

Assuming you are sure there is a match, then try:

Private Sub CboJobNo_Change()
    LblProjName.Caption = Application.WorksheetFunction.VLookup(Val(CboJobNo.Value), Range("Job_List"), 2, False)
End Sub

 

[Mike Blackman]

Hi,

It may well be worth declaring which sheet your lookup range is on as this can cause issues at times:

Private Sub CboJobNo_Change()
    LblProjName.Caption = Application.WorksheetFunction.VLookup(Val(CboJobNo.Value), Sheets("MySheet").Range("Job_List"), 2, False)
End Sub

 

[hstaubyn]

Brilliant, the "val(..." addition to the code works perfectly.

I didn't think of that because the combobox is populated from the same cells that appear in the left hand column of the lookup range! One would have thought they would match formats (or whatever property was causing the problem) because of that.

Anyway, one step closer to ultimate VBA knowledge, thanks!

 

[Norie]

If the combobox is populated from the left column why not use the combobox's ListIndex to get the data instead of VLookUp?

Then there would be no need to worry about formats.

Private Sub CboJobNo_Change()
 
    If CboJobNo.ListIndex <> -1 Then
        LblProjName.Caption = Range("Job_List").Cells(1, 1).Offset(CboJobNo.ListIndex, 1)
    End If
End Sub
 
Private Sub UserForm_Initialize()
    CboJobNo.List = Range("Job_List").Resize(, 1).Value
End Sub