compile error: Help Please

[eltonstaka]

Block if without end if

Private Sub Worksheet_Change(ByVal Target As Range)
' MsgBox (Target.Rows)
If Target.Column = 9 Or Target.Column = 10 Then
Dim v1 As Single
Dim vx As Single
v1 = Cells(Target.Row, 9)
vx = Cells(Target.Row, 10)
If v1 > 1 And vx > 1 Then
Dim ac As Worksheet
If Cells(Target.Row, 8) = 1 Then
Set ac = Worksheets("Kuota RF_1_92")
Else
If Cells(Target.Row, 8) = 1 Then
Set ac = Worksheets("Kuota RF_1_90")
Else
If Cells(Target.Row, 8) = 3 Then
Set ac = Worksheets("Kuota RF_1_88")
End If

For i = 2 To 1000
If ac.Cells(i, 1) = v1 And ac.Cells(i, 2) = vx Then
Cells(Target.Row, 11) = ac.Cells(i, 3)
Exit For
End If

Next
End If


End Sub

 

[Jonmo1]

Each IF needs an End If (unless the 'action if true' is written on the same line as the if expression)
So you have 6 If's that need an End If, but you only have 2 End Ifs

You're putting new IF's in the Else part of a previous IF.
That If in the Else part is it's own IF, and needs an End if too

This compiles and runs without error, but I have no idea if it actually does what you want..

Private Sub Worksheet_Change(ByVal Target As Range)
' MsgBox (Target.Rows)
If Target.Column = 9 Or Target.Column = 10 Then
    Dim v1 As Single
    Dim vx As Single
    v1 = Cells(Target.Row, 9)
    vx = Cells(Target.Row, 10)
    If v1 > 1 And vx > 1 Then
        Dim ac As Worksheet
    End If
    If Cells(Target.Row, 8) = 1 Then
        Set ac = Worksheets("Kuota RF_1_92")
    Else
        If Cells(Target.Row, 8) = 1 Then
            Set ac = Worksheets("Kuota RF_1_90")
        Else
            If Cells(Target.Row, 8) = 3 Then
                Set ac = Worksheets("Kuota RF_1_88")
            End If
        End If
    End If
    
    For i = 2 To 1000
    If ac.Cells(i, 1) = v1 And ac.Cells(i, 2) = vx Then
        Cells(Target.Row, 11) = ac.Cells(i, 3)
        Exit For
    End If
    
    Next
End If

End Sub

 

[mwrohr]

That is a hell of a nested if...but this compiled correctly for me. I've found tabbing on new lines within a statement helps to find where to close it.

Private Sub Worksheet_Change(ByVal Target As Range)
Dim v1 As Single, vx As Single
Dim ac As Worksheet
Dim i As Integer

    If Target.Column = 9 Or Target.Column = 10 Then
        v1 = Cells(Target.Row, 9)
        vx = Cells(Target.Row, 10)

        If v1 > 1 And vx > 1 Then
            If Cells(Target.Row, 8) = 1 Then
                Set ac = Worksheets("Kuota RF_1_92")
                Else
                    If Cells(Target.Row, 8) = 1 Then
                        Set ac = Worksheets("Kuota RF_1_90")
                        Else
                            If Cells(Target.Row, 8) = 3 Then
                                Set ac = Worksheets("Kuota RF_1_88")
                            End If
                    End If
            End If
        End If

        For i = 2 To 1000
            If ac.Cells(i, 1) = v1 And ac.Cells(i, 2) = vx Then
                Cells(Target.Row, 11) = ac.Cells(i, 3)
                Exit For
            End If
        Next
    End If

End Sub

 

[eltonstaka]

thank you Jonmo1 i resolve

 

[Jonmo1]

Glad to help, thanks for the feedback