Data file imports using variables

[krissz]

I am trying to set up an application which allows a user to import a text file (say a credit card statement, expenses, etc) into excel, work on it (cost codes, tax, etc) & then output a verified text file which can be used to import the data in the accounts system.
If I hard code the connection string, it works perfectly.

 With ActiveSheet.QueryTables.Add(Connection:=_
         "TEXT;J:\ACCOUNTS\Credit Cards\2016_\statement_201604.csv", _
         Destination:=Range ("$B$1"))
        .Name = "statement_201604"
        .FieldNames = True
        .RowNumbers = False
        .FillAdjacentFormulas = False
        .PreserveFormatting = True
        .RefreshOnFileOpen = False
        .RefreshStyle = xlInsertDeleteCells
        .SavePassword = False
        .SaveData = True
        .AdjustColumnWidth = True
        .RefreshPeriod = 0
        .TextFilePromptOnRefresh = False
        .TextFilePlatform = 1252
        .TextFileStartRow = 1
        .TextFileParseType = xlDelimited
        .TextFileTextQualifier = xlTextQualifierDoubleQuote
        .TextFileConsecutiveDelimiter = False
        .TextFileTabDelimiter = True
        .TextFileSemicolonDelimiter = False
        .TextFileCommaDelimiter = True
        .TextFileSpaceDelimiter = False
        .TextFileColumnDataTypes = Array(4, 1, 1, 1, 1, 1, 1)
        .TextFileTrailingMinusNumbers = True
        .Refresh BackgroundQuery:=False
    End With

However, when I try to use variables for the connection string, it fails

    CSV_Name = Range("Master!B3").Value & Range("Master!B17").Value
    CSV_Name = Chr(39) & "TEXT;" & CSV_Name & ".CSV" & Chr(39)
    
    With ActiveSheet.QueryTables.Add(Connection:=CSV_Name, Destination:=Range("$A$2"))
        .Name =CSV_Name
        .FieldNames = True
        .RowNumbers = False
        etc

I have been googling but can find little apart from SQL connections. It's probably very simple, but I cannot resolve it.

 

[Joe4]

After the two rows where you create the variable, add a Message Box to return its value:

MsgBox CSV_Name

When you run it, does the message box return:
TEXT;J:\ACCOUNTS\Credit Cards\2016_\statement_201604.csv
If not, modify the variable as needed so it does.

Also, do NOT set the .Name property equal to CSV_Name. That is the name of the sheet, and slashes are not allowed in the name.
Just make it something like:

.Name = "Sheet1"

or

.Name = "statement"

 

[krissz]

Joe4

 

[krissz]

Joe4
Thanks for you advice. I now have the correct string but get an Run-time error 1004 when using the variable but it works smoothly with the text. Just in case, I have recorded a macro for this action several times.
I am confused.

 

[krissz]

Joe
I have solved the problem. I was adding extra CHR(34), originally CHR(39) when defining CSV_File.
This is now that part of the code:
'Import CSV file

    CSV_Name = Range("Master!B3").Value & Range("Master!B17").Value
    CSV_Name = "TEXT" & Chr(59) & CSV_Name & ".CSV"
    
    With ActiveSheet.QueryTables.Add(Connection:=CSV_Name, Destination:=Range("$A$2"))
'        "TEXT;J:\ACCOUNTS\Credit Cards\2016\statement_201604.csv", Destination:=Range("$B$1"))
        .Name = "statement_201604"
        .FieldNames = True
        .RowNumbers = False
       etc

Found the answer at:

excel vba - CSV Import into a spreadsheet fails on QueryTables method - Stack Overflow

Thanks for your help