Error Handling Problem

[Zabman]

Hi,

I have the following errorhandling procedure, which is located at the end of my procedure.

When the code reaches this, even though I have already set errorhandling back to default (on error goto 0), it is going through this code even though there is no error.

Have I written this incorrectly, or put it in the wrong place? I have spent hours trying to work this out!

ErrorHandler:
    Select Case Err
        Case 1004, 13
            sData = "No Data"
            Resume Next
    End Select

 

[GTO]

Changing the errror handling back to ...Goto 0 resets (clears) any current existing error. By example:

Sub exa()
Dim lNumber As Long
    
    On Error Resume Next
    lNumber = "Text"
    
    If Err.Number > 0 Then
        MsgBox Err.Description
    End If
    
    lNumber = "Still Text"
    On Error GoTo 0
    If Err > 0 Then
        MsgBox "I won't show"
    End If
End Sub

 

[Zabman]

Hi,

The problem wasn't so much the error handling, but the fact that the code went through the errorhandler at the end of the sub despite there being no error. It would see the resume statement and try to resume when there was no error to resume from.

Your idea of the if err.number>0 has helped with a fix though! I am now using this, so it doesnt matter that it cycles through at the end. Thanks!!!

ErrorHandler:
    If Err.Number > 0 Then
        Select Case Err
            Case 1004, 13
                sData = "No Data"
                Resume Next
            Case Else
                On Error GoTo 0
                Resume
        End Select
    End If

 

[GTO]

Hi,

The problem wasn't so much the error handling, but the fact that the code went through the errorhandler at the end of the sub despite there being no error...

Okay, I misunderstood a bit. Do you have an 'Exit Sub' (or Exit Function) right above ErrorHandler: ? If not, put one in, as this way it only gets to the ErrorHandler: line if there is an error. I am presuming that you have On Error GoTo ErrorHandler someplace up in the code?

 

[Zabman]

Great - that works fantastic - For some reason, I have never liked the exit sub statement, but right above the error handler I guess it does its job