Error on a Simple If Then statement

[jUStPunkin]

Hi all,

I'm a bit stumped by this, because the code seems simple enough. I have a criteria, set one way, I want certain sheets to show, set another way, I want other sheets to show.

If my value for "G_CapturedAbove" is N, it works fine.
If my value for "G_CapturedAbove" is Y, it does not hide the spout sheet. Any thoughts?

I have tried this with the ElseIf to just be a Else without the range value, but that didn't work either.

    If Range("G_CapturedAbove").Value = ("N") Then
        Sheets("Spouts").Visible = True
        Sheets("Spouts2").Visible = False
        Sheets("Redistribution Calculations").Visible = False

    ElseIf Range("G_CapturedAbove").Value = ("Y") Then

        Sheets("Spouts").Visible = False
        Sheets("Spouts2").Visible = True
        Sheets("Redistribution Calculations").Visible = True

    End If

 

[dmt32]

Hi
as you are just toggling a True / False state see if this update to your code does what you want

        Dim IsNo As Boolean
        IsNo = UCase(Range("G_CapturedAbove").Value) = "N"
        Sheets("Spouts").Visible = IsNo
        Sheets("Spouts2").Visible = Not IsNo
        Sheets("Redistribution Calculations").Visible = Not IsNo

Dave

 

[jUStPunkin]

So, that is closer. That won't display the "Spouts" sheet, but it does fix the problem of both showing when Value is Y

There is other code in this spreadsheet (I'm trying to do a lot, and not a very good code writer), so I suspect another variable is triggering the missing sheet.

I'm going to continue to troubleshoot the rest of the code, and quite possibly rewrite what I have.

Edit: Thanks for this, I actually found the other errant code that was causing issues and fixed it!

 

[DanteAmor]

The code works for me.

The comparison is case sensitive.
So to always compare with uppercase:

  If UCase(Range("G_CapturedAbove").Value) = "N" Then
    Sheets("Spouts").Visible = -1
    Sheets("Spouts2").Visible = 0
    Sheets("Redistribution Calculations").Visible = 0
  ElseIf UCase(Range("G_CapturedAbove").Value) = "Y" Then
    Sheets("Spouts").Visible = 0
    Sheets("Spouts2").Visible = -1
    Sheets("Redistribution Calculations").Visible = -1
  End If

Or this simplified way:

  Sheets("Spouts").Visible = UCase(Range("G_CapturedAbove").Value) = "N"
  Sheets("Spouts2").Visible = UCase(Range("G_CapturedAbove").Value) <> "N"
  Sheets("Redistribution Calculations").Visible = UCase(Range("G_CapturedAbove").Value) <> "N"

Or this:

  Dim gc As String
  gc = UCase(Range("G_CapturedAbove").Value)
  Sheets("Spouts").Visible = gc = "N"
  Sheets("Spouts2").Visible = gc <> "N"
  Sheets("Redistribution Calculations").Visible = gc <> "N"

Note: If you have other code that affects your code, you should put it here for us to review.

--------------
Let me know the result and I'll get back to you as soon as I can.
Cordially
Dante Amor
--------------​

 

[dmt32]

Edit: Thanks for this, I actually found the other errant code that was causing issues and fixed it!

it would be other code causing that issue but glad you found & resolved it

appreciate your feedback

Dave