Error with If/Else macro code

Noobette

New Member
Joined
Oct 27, 2008
Messages
44
I've got an error here, and I need to modify it to perform better.

My data looks like this in column A.

apple
apple
Orange
Orange
apple
pear
apple
carrot
Orange
pear

<COLGROUP><COL style="WIDTH: 48pt" width=64><TBODY>
</TBODY>

Code:
Sub WorkSheet_Fruit()
For i = 1 To 10
yum = Sheet1.Cells(i, 2).Value
If yum = "apple" Then
Sheet1.Cells(i, 3).Value = "a"
ElseIf yum = "orange" Then
Sheet1.Cells(i, 3).Value = "o"
ElseIf yum < "pear" Then
Sheet1.Cells(i, 3).Value = "p"
Else
Sheet1.Cells(i, 3).Value = "veggie"
End If
Next i
End Sub

The error is that the code returns "p" in each of the 10 cells in column C.
I'd like to modify it to be flexible with a variable number of rows in Column A.

Any help is appreciated!
 

Excel Facts

How to show all formulas in Excel?
Press Ctrl+` to show all formulas. Press it again to toggle back to numbers. The grave accent is often under the tilde on US keyboards.
Try this:
Code:
Sub WorkSheet_Fruit()
lr = Cells(Rows.Count, "A").End(xlUp).Row 'get last filled row
For i = 1 To lr
    Select Case Sheet1.Cells(i, 1).Value 'col 1 instead of 2!
        Case "apple"
            Sheet1.Cells(i, 3).Value = "a"
        Case "orange"
            Sheet1.Cells(i, 3).Value = "o"
        Case Is < "pear"
            Sheet1.Cells(i, 3).Value = "p"
        Case Else
            Sheet1.Cells(i, 3).Value = "veggie"
    End Select
Next i
End Sub
 
Upvote 0

Forum statistics

Threads
1,211,984
Messages
6,105,216
Members
447,957
Latest member
Basildon

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top