Function: String as input

[mtheriault2000]

Hello again

I want to create a function to manipulate strings

Public Function NextBartime(ByRef t1 As String, ByRef t2 As String) As String

' Part of the code by  Rick Rothstein

Dim Realt1, realt2 As Date
Dim Newtime As String

    Realt1 = CDate(Format(t1, "@@@@-@@-@@ @@@@@@@@"))
    realt2 = CDate(Format(t2, "@@@@-@@-@@ @@@@@@@@"))
    NexBartime = Format((realt2 - Realt1) + realt2, "yyyymmdd hh:mm:ss")
End Function

Sub testnextbar()
Dim t1, t2, rt As String

t1 = "20110922 18:57:00"
t2 = "20110922 19:00:00"

'Call the function 
rt = NextBartime(t1, t2)

End Sub

My Sub give an error on T1 as an incompatible argument

Any idea where I miss the point???

Martin

 

[mtheriault2000]

Hello again

I want to create a function to manipulate strings

Public Function NextBartime(ByRef t1 As String, ByRef t2 As String) As String

' Part of the code by  Rick Rothstein

Dim Realt1, realt2 As Date
Dim Newtime As String

    Realt1 = CDate(Format(t1, "@@@@-@@-@@ @@@@@@@@"))
    realt2 = CDate(Format(t2, "@@@@-@@-@@ @@@@@@@@"))
    NexBartime = Format((realt2 - Realt1) + realt2, "yyyymmdd hh:mm:ss")
End Function

Sub testnextbar()
Dim t1, t2, rt As String

t1 = "20110922 18:57:00"
t2 = "20110922 19:00:00"

'Call the function 
rt = NextBartime(t1, t2)

End Sub

My Sub give an error on T1 as an incompatible argument

Any idea where I miss the point???

Martin

Resolve by modifying Byref to ByVal in the function definition

Martin

 

[mikerickson]

This statement

Dim t1, t2, rt As String

is declaring t1 as Variant, t2 as Variant and rt As String.

Try

Dim t1 As String, t2 As String, rt As String

BTW, in the last line of the function NexBartime is missing a "t".

 

[mikerickson]

I just saw that you fixed it with ByVal.
That's clever, by making a new variable address, you forced Excel to evaluate the funtion arguments, triggering the automatic type conversion.

Slick solution, I'll have to remember that one.

 

[mtheriault2000]

Hello Mike

Did learned two thing

Dim T1, T,T2 ,RT as string

Create variable with a different status. I did the test with
T1 = 2 Return: 2
RT = 3 Return : "3"

by making a new variable address, you forced Excel to evaluate the funtion arguments, triggering the automatic type conversion.

That was not intentional..... But you putting emphases on that made me understand that point

Have a great day

Martiin