Goto Statement is incorrectly terminating the Nested IF Block - What am I doing wrong.

[JeffGrant]

Hi All,

I have this scenario.

If Then
elseif then
if condition A Then
Goto Label A
end if

Label A
elseif then
if condition B Then
Goto Label B
end if

Label B

etc for Label C, D & E


End if (code is jumping to here when condition A is true)

More code


The idea being that if condition A is true, then jump to the next Else If to check Condition B and so on.

But what I am finding is the if condition A is true, instead of following the Goto Label A instruction, all remaining Else If conditions are missed because the entire If block is terminated

I don't understand why the code is not jumping to the Label to continue the checking.

Any guidance is very much appreciated please.

Thanks in advance

 

[offthelip]

If your logic is very much to do with controlling a state machine about the status bets on four legged animals then you might be interested in this very simple statemachine that I developed for somebody else. It is all controlled from one worksheet and very simple worksheet change routine. The point of the software is that it is generic all the logic is controlled by what is written on the worksheet. States are change by typing TRUE into any of the yellow cells. starting from dormant the only one that changes state is to type into B3 to turn it on. here is the code:

Private Sub Worksheet_Change(ByVal Target As Range)
colno = Target.Column
If colno = 2 Then
rowno = Target.Row
If rowno > 2 And rowno < 11 Then
currentstate = Cells(15, 4)
trigger = Cells(rowno, 1)
rules = Range(Cells(1, 5), Cells(12, 7))
For i = 2 To 12
If rules(i, 2) = trigger And rules(i, 1) = currentstate Then
currentstate = rules(i, 3)
Cells(15, 4) = currentstate
Cells(rowno, colno) = False
Exit For
End If
Next i
End If
End If
End Sub

here is the worksheet
I have just noticed that B5 is TRUE I suggest typing FALSE in there to start with

State Machine.xlsm
	A	B	C	D	E	F	G
1	State Diagram Boxes and lines				Rules
2	Triggers	equated to Address	States		Initial State	Trigger	Final State
3	Turn On	FALSE	Dormant		Dormant	Turn On	Running
4	Turn Off	FALSE	Running		Running	Turn Off	Dormant
5	Trigger Lay	TRUE	Lay Triggered		Running	Trigger Lay	Lay Triggered
6	Trigger Back	FALSE	Back Triggered		Running	Trigger Back	Back Triggered
7	Bet Confirmed	FALSE	Lay Placed		Lay Triggered	Bet Confirmed	Lay placed
8	Error	FALSE	Back Placed		Back Triggered	Bet Confirmed	Back Placed
9	Trigger Lay Close	FALSE	Lay Close Triggered		Lay Triggered	Error	Running
10	Trigger Back Close	FALSE	Back Close Triggered		Back Triggered	Error	Running
11					Lay placed	Trigger Lay Close	Running
12					Back Placed	Trigger Back Close	Running
13
14
15			Current State	Dormant
Sheet1

 

[JeffGrant]

Hi Guys,
I have resolved the issue by going back a couple of versions, and rethinking the nested if structure. All seems to be working fine. I just needed a couple of days away from this project to rehash it my mind.
However, offthelip, you have introduced a new way of thinking that could well be a much more efficient structure. I will defintely spend some time investigating this strategy.
Thansk to all.