Grouping command button

[jasman]

Hi. I have some images which I have written code to group them when a command button is clicked. but it also groups the command button with the images- anyway around this? Hers my code?

Thanks


Private Sub CommandButton2_Click()
Sheets("Sheet2").Select
ActiveSheet.Shapes.SelectAll
Selection.ShapeRange.GROUP.Select
End Sub

 

[Domenic]

To exclude OLE control objects, such as a command button, try...

[font=Verdana][color=darkblue]Private[/color] [color=darkblue]Sub[/color] CommandButton2_Click()

    [color=darkblue]Dim[/color] MyArray() [color=darkblue]As[/color] [color=darkblue]String[/color]
    [color=darkblue]Dim[/color] Shp [color=darkblue]As[/color] Shape
    [color=darkblue]Dim[/color] Cnt [color=darkblue]As[/color] [color=darkblue]Long[/color]
    
    [color=darkblue]For[/color] [color=darkblue]Each[/color] Shp [color=darkblue]In[/color] Sheets("Sheet2").Shapes
        [color=darkblue]If[/color] Shp.Type <> 12 [color=darkblue]Then[/color]
            [color=darkblue]ReDim[/color] [color=darkblue]Preserve[/color] MyArray(Cnt)
            MyArray(Cnt) = Shp.Name
            Cnt = Cnt + 1
        [color=darkblue]End[/color] [color=darkblue]If[/color]
    [color=darkblue]Next[/color] Shp
    
    Sheets("Sheet2").Shapes.Range(MyArray).Group.Select

[color=darkblue]End[/color] [color=darkblue]Sub[/color]
[/font]

Actually, since the code resides within the worksheet module, try replacing...

Sheets("Sheet2").Shapes

with

Me.Shapes

and

Sheets("Sheet2").Shapes.Range(MyArray).Group.Select

with

Me.Shapes.Range(MyArray).Group.Select

This way you won't need to modify the code if the sheet name changes.

 

[jasman]

thanks but it keeps showing an error on line

Sheets("Sheet2").Shapes.Range(MyArray).Group.Select

says parameter error

 

[Domenic]

says parameter error

Is that the exact error message? I've tested it on Excel 2010 and it seems to work fine.

 

[jasman]

the error says:
the specified parameter has an invalid value
runtime error 1004

thanks