Help for editing code in userform

[azizls4]

hello
I have nice userform that I took from someone. It opens PDF files via userform. I want to modify some simple things in it.
When I put the combobox on sheet1, I want to be the path of PDF Folder C:\Users\Desktop\testpdf1\
and When I put the combobox on sheet2, I want to be the path of PDF Folder C:\Users\Desktop\testpdf2\
So that the PDF files appear in the listbox
thank you

excel userform

 

[Bosquedeguate]

hello
I have nice userform that I took from someone. It opens PDF files via userform. I want to modify some simple things in it.
When I put the combobox on sheet1, I want to be the path of PDF Folder C:\Users\Desktop\testpdf1\
and When I put the combobox on sheet2, I want to be the path of PDF Folder C:\Users\Desktop\testpdf2\
So that the PDF files appear in the listbox
thank you

excel userform

Do you want the path names displayed? Where? TextBox2?

 

[azizls4]

Do you want the path names displayed? Where? TextBox2?

Yes, path display in TextBox 2, and PDF files shows in listbox
It means if sheet1 is active, The PDF files of path C:\Users\Desktop\testpdf1\ displayed in listbox
and if sheet2 is active, The PDF files of path C:\Users\Desktop\testpdf2\ displayed in listbox
So I view ( or open) pdf file from the listbox by Double click on it

 

[Bosquedeguate]

Yes, path display in TextBox 2, and PDF files shows in listbox
It means if sheet1 is active, The PDF files of path C:\Users\Desktop\testpdf1\ displayed in listbox
and if sheet2 is active, The PDF files of path C:\Users\Desktop\testpdf2\ displayed in listbox
So I view ( or open) pdf file from the listbox by Double click on it

What if the 3rd sheet is selected? does that change the path as well? Right now 3 Sheet names are listed in the ComboBox

 

[azizls4]

What if the 3rd sheet is selected? does that change the path as well? Right now 3 Sheet names are listed in the ComboBox

also path C:\Users\Desktop\testpdf3\
for sheet3

 

[Bosquedeguate]

Try changing the following Sub(s) in your User Form code

Private Sub ComboBox1_Change()
  On Error GoTo s
  With ComboBox1
    If .ListIndex <> -1 Then
      ThisWorkbook.Sheets(ComboBox1.Text).Activate
      TextBox2 = .List(.ListIndex, 1)
    End If
  End With
s:
End Sub

and

Private Sub UserForm_Activate()
  Dim ws As Worksheet
  Dim folder As String
  
  For Each ws In ThisWorkbook.Worksheets
    With ComboBox1
      .AddItem ws.Name
      Select Case LCase(ws.Name)
        Case "sheet1"
           folder = "testpdf1\"
        Case "sheet2"
          folder = "testpdf2\"
        Case Else
          folder = "testpdf3\"
      End Select
      .List(.ListCount - 1, 1) = "C:\Users\Desktop\" & folder
    End With
  Next ws
End Sub

 

[azizls4]

Try changing the following Sub(s) in your User Form code

Private Sub ComboBox1_Change()
  On Error GoTo s
  With ComboBox1
    If .ListIndex <> -1 Then
      ThisWorkbook.Sheets(ComboBox1.Text).Activate
      TextBox2 = .List(.ListIndex, 1)
    End If
  End With
s:
End Sub

and

Private Sub UserForm_Activate()
  Dim ws As Worksheet
  Dim folder As String
 
  For Each ws In ThisWorkbook.Worksheets
    With ComboBox1
      .AddItem ws.Name
      Select Case LCase(ws.Name)
        Case "sheet1"
           folder = "testpdf1\"
        Case "sheet2"
          folder = "testpdf2\"
        Case Else
          folder = "testpdf3\"
      End Select
      .List(.ListCount - 1, 1) = "C:\Users\Desktop\" & folder
    End With
  Next ws
End Sub

It did not work,
when I change between the sheets, the path appears in the textbox only, but the pdf files do not appear in the listbox

 

[Bosquedeguate]

It did not work,
when I change between the sheets, the path appears in the textbox only, but the pdf files do not appear in the listbox

Do you have the following folder on your desktop? C:\Users\Desktop?
On my laptop I have C:\Users\username\Desktop ... where user name is the user's ID.
Please make sure the path name you gave me is correct.

 

[azizls4]

Do you have the following folder on your desktop? C:\Users\Desktop?
On my laptop I have C:\Users\username\Desktop ... where user name is the user's ID.
Please make sure the path name you gave me is

you are right
(C:\Users\Desktop\) this path is just an example
i change it with correct path on my laptop
I copied the correct path from the folder properties And put it in the code here
.List(.ListCount - 1, 1) = "C:\Users\Desktop\" & folder
But unfortunately it didn't work

 

[Bosquedeguate]

Do you have the following folder on your desktop? C:\Users\Desktop?
On my laptop I have C:\Users\username\Desktop ... where user name is the user's ID.
Please make sure the path name you gave me is correct.

This works like it supposed to work on my laptop. Are you sure you have your path names defined correctly, and that you have PDF in the desired folders?


Move the following lines of code from the UserForm_Activate Sub
to UserForm_Initialize. Having this code that sets the values for the ComboBox executes after opening a PDF file.
When you return to the UserForm after viewing a PDF the sheets were added a 2nd time to the ComboBox.
By putting the Code in the UserForm_Initialize Sub the ComboBox is set up only once.

  Dim ws As Worksheet
  Dim folder As String
  
  For Each ws In ThisWorkbook.Worksheets
    With ComboBox1
      .AddItem ws.Name
      Select Case LCase(ws.Name)
        Case "sheet1"
          folder = "testpdf1\"
        Case "sheet2"
          folder = "testpdf2\"
        Case Else
          folder = "testpdf3\"
      End Select
      .List(.ListCount - 1, 1) = "C:\Users\forrest\Desktop\" & folder
    End With
  Next ws