Hide Range Code Note Working

[jUStPunkin]

I'm a relative newbie at VBA, but I have a question about some code I've written. I've actually copied and modified this from another routine I've written (which works), but for some reason, I can't get this to work.

I have a cell where you choose one of four options (straight, tee, H or other), and based on your selection, certain rows should be hidden. It's not working though. Can anybody see what I've done wrong?

Private Sub Worksheet_Change(ByVal Target As Range)
    Select Case Worksheets("Nozzle").Range("$H$10")
        Case Is = "Straight"
            Worksheets("Nozzle").Range("$A$28:$D$31").EntireRow.Hidden = True
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
        Case Is = "Tee"
            Worksheets("Nozzle").Range("$A$30:$D$31").EntireRow.Hidden = True
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
        Case Is = "H"
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
        Case Is = "Other"
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
        Case Else
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
            Worksheets("Nozzle").Range("$A$25:$D$31").EntireRow.Hidden = False
                        
        End Select
        
         
End Sub

 

[Crizznitch]

I think if you switch the lines hiding code and unhiding code, it should solve your problem.

Currently it is hiding rows, and then unhiding the rows right after that.

 

[jUStPunkin]

I think if you switch the lines hiding code and unhiding code, it should solve your problem.

Currently it is hiding rows, and then unhiding the rows right after that.

Put the falses first, in other words.

Thanks, I'll give it a try.

 

[Crizznitch]

Yep.

Also, you could shorten the code with:

        Case Is = "Straight"
            Worksheets("Nozzle").Rows("25:31").Hidden = False
            Worksheets("Nozzle").Rows("28:31").Hidden = True
        Case Is = "Tee"
            Worksheets("Nozzle").Rows("25:31").Hidden = False
            Worksheets("Nozzle").Rows("30:31").Hidden = True

 

[jUStPunkin]

Excellent. Thank you very much for your quick and helpful answers