Logic statement trouble

[Mr930]

I am passing in these values:
szOld=PDP
szNew=empty

Function FindType(szOld As String, szNew As String)
If ((szOld = "PDP" Or szOld = "PDNP" Or szOld = "PUD") And IsEmpty(szNew)) Then
FindType = "delete"
End If
End Function

Something must be wrong with my logic, or I am still thinking in C, but it seems like my IF statement should evaluate to true, but it is false.

Can someone guide me?

thanks
Fred Emmerich

 

[MrKowz]

What is happening is that szNew isn't empty, is it a null string: ""

Try:

Function FindType(szOld As String, szNew As String)
If (szOld = "PDP" Or szOld = "PDNP" Or szOld = "PUD") And szNew = "" Then
    FindType = "delete"
End If
End Function

 

[Norie]

What exactly is szNew?

 

[Mr930]

What exactly is szNew?

It was a variable from a cell with nothing in it.

 

[MrKowz]

According to the VBA Help file for IsEmpty:

"IsEmpty will only return TRUE for a variable that is unitialized, or is explicitly set to Empty."

Since you initialized the variable, and it is not explicitly set to EMPTY, IsEmpty is evaluating to FALSE.

 

[Norie]

To test for an 'empty' string you could try checking the length.

If (...) And Len(szNew)=0 Then