Macro Stops

Jamm_027

Board Regular
Joined
Sep 10, 2007
Messages
249
Why does my macro stop?

My macro accomplishes exactly what I want it to do but I have to run it twice.

The first time I run it. It stops after selecting the range E6:E300. So, then I have to run it again and it will delete all the rows correctly for me. How can I make it run all the way thru?

Code:
Sub Delete_X()

Application.ScreenUpdating = False

Dim c As Range
For Each c In Selection
    
Range("E6:E300").Select

If c.Value = Range("$IT$1").Value Then c.EntireRow.Delete
Next

Application.ScreenUpdating = True

End Sub
 

Excel Facts

Control Word Wrap
Press Alt+Enter to move to a new row in a cell. Lets you control where the words wrap.
You have to loop backwards whenh deleting rows. Try

Code:
Sub Delete_X()

Application.ScreenUpdating = False

Dim i As Long
For i = 300 To 6 Step -1
    

    If Range("E" & i).Value = Range("$IT$1").Value Then Rows(i).Delete
Next i

Application.ScreenUpdating = True

End Sub
 
Upvote 0
When deleting rows, it's best to work your way up. And you don't need to select cells to perform actions on them.. Something like this:

Code:
Sub Delete_X()
Application.ScreenUpdating = False
Dim i As Long
For i = 300 To 6 Step -1
    If Cells(i, 5) = Range("$IT$1") Then Cells(i, 5).EntireRow.Delete
Next
Application.ScreenUpdating = True
End Sub
 
Upvote 0

Forum statistics

Threads
1,224,527
Messages
6,179,337
Members
452,907
Latest member
Roland Deschain

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top