Macro to delwete zero values

[howard]

I have written code to delete all rows from row 8 onwards where there is a zero value in column 8, but cannot get it to work

Your assistance in resolving the matter is most appreciated

Sub Delete_Zero_Values()
finalrow = Cells(65536, 8).End(xlUp).Row
For i = finalrow To 8 Step -1
If Cells(i, 8).Value = "0" Then
Cells(i, 8).EntireRow.Delete
End If
Next i
End Sub

 

[kpark91]

Which module is the code in?
It must be in the corresponding worksheet module in order for your code to work.

 

[howard]

Thanks for the reply. The macro is in the worksheet module. There are 30000 rows of data and it seems to be going into a loop. Is my code correct or does it need to be amended?

 

[howard]

Macro has finally run. I thought there was a problem, but due to +- 30000 rows it took +- 3 mins to run

 

[kpark91]

Deleting rows always take a long time.
there is a better algorithm but it requires sorting then deleting.

 

[taurean]

The other reason could be there will be formulas which might be getting calculated every time a row is deleted.