Nearly there i think - Where am i going wrong with the class

[mahmed1]

Hi

I am trying to set up a class that has a Team name, Player Name and Players (Collection to add players) but i am getting an error saying variable not set. Please advise if im on the right track and give some pointers to where i can improve

Thank You

P.s how would i encorporate into the NEW class multiple names from the sheet1 Range A2:A10 where it hold the player names

Do i need to create an instance for each player name in the loop or can i leave it as 1 instance?

i.e

For i = 2 to 10

Set AddPlayer = New PlayersTeam.Player.Name = Sheets("Sheet1").Range("A" & i).value
Players.Add Player, Team.Player.Name
Set Players = Nothing
Next i

I have set up these 3 classes.

Team clas has 2 properties - Name and Player (class) to access Player Class

Normal Module

Sub test()
Dim Team As Team
Dim Player As Player
Dim Players As Players

Set Team = New Team
Set Player = New Player
Set Players= New Players

Team.Player.Name = "Joe Bloggs"
Players.Add Player, Team.Player.Name

End Sub

Team Class module

Private pName As String
Private pPlayer As Player
Public Property Let Name(value As String)
pName = value
End Property
Public Property Get Name() As String
Name = pName
End Property
Public Property Let Player(value As Player)
Set pPlayer = value
End Property
Public Property Get Player() As Player
Set Player = pPlayer
End Property

Player Class module

Private pName As String
Public Property Let Name(value As String)
pName = value
End Property
Public Property Get Name() As String
Name = pName
End Property

Players Class Module (Collection)

Private pAddPlayers As Collection

Private Sub Class_Initialize()
Set pAddPlayers = New Collection
End Sub

Sub Add(Item As Player, Key As String)
    pAddPlayers.Add Item, Key
End Sub

Public Property Get Count() As Long
Count = pAddPlayers.Count
End Property

Public Property Get Item(NameORnumber As Variant) As Player
Set Item = pAddPlayers.Item(NameORnumber)
End Property

 

[Kyle123]

Use code tags

 

[mahmed1]

For some reason its getting printed all weird

Hi Kyle - Once again Thank you so much. I think I now have a really good understanding in regards to class modules thanks to yourself and I am practicing to get more used to it
I did not know that you could pass a collection to another collection
From my understanding, would I be correct in saying the way this code is working is something like this

Public Function AddTeam(TeamName As String) As Team
If Not cTeams.Exists(TeamName) Then
Dim t As Team
Set t = New Team
t.Name = TeamName
cTeams.Add TeamName, t
End If
Set AddTeam = cTeams(TeamName)
End Function

Public Function AddTeamAndPlayer(TeamName As String, PlayerName As String) As Player
Set AddTeamAndPlayer = AddTeam(TeamName).AddPlayer(PlayerName)
End Function

Public Function AddTeamAndPlayer(TeamName As String, PlayerName As String) As Player
'Set AddTeamAndPlayer = Whatever is in Addteam and then whatever is within that (Like a nested if FUNCTION)
Set AddTeamAndPlayer = AddTeam(TeamName).AddPlayer(PlayerName)
End Function

So by Setting AddTeam by using the AddTeam function is saying

Set AddTeam to collection("Boys Team")
so now this line becomes collection Boys Team

Set AddTeamAndPlayer = AddTeam(Collection "Boys Team") 
.AddPlayer(PlayerName)

and then it processes the next part

.AddPlayer(PlayerName)

and by setting the player to the AddTeam its setting AddPlayer to the collection which holds that player details.
P.s why is the SET and AS PLAYER needed in the AddTeamandPlayer Function as I cant see how this is being used again in the main code so could I have not done

Public Function AddTeamAndPlayer(TeamName As String, PlayerName As String)
AddTeamAndPlayer = AddTeam(TeamName).AddPlayer(PlayerName)
End Function

 

[Kyle123]

No, that's not how it works. We aren't passing about a collection/dictionary, we are passing an element of that collection which is either an object of type Team or a Player object.
The syntax for accessing an element from a collection or dictionary is as follows:

[Set] myVariable = Collection(Key) 'Set required for objects

Or as in the above

Set AddTeam = cTeams(TeamName)

So this line:

Set AddTeamAndPlayer = AddTeam(TeamName).AddPlayer(PlayerName)

Expanded out would be written like this:

Dim myTeam as Team
Dim myPlayer as Player

set myTeam = AddTeam(TeamName) 
set myPlayer = myTeam.AddPlayer(PlayerName)
set AddTeamAndPlayer = myPlayer

As this should demonstrate, we are just referencing objects within the collections, not the collections themselves

P.s why is the SET and AS PLAYER needed in the AddTeamandPlayer Function as I cant see how this is being used again in the main code so could I have not done

Public Function AddTeamAndPlayer(TeamName As String, PlayerName As String)

AddTeamAndPlayer = AddTeam(TeamName).AddPlayer(PlayerName)

End Function

<tbody>
</tbody>

No, you couldn't; whilst you do not actually access the returned player in the calling code, the option is there should you wish to do so. If you wanted to remove this functionality, you wouldn't use a function since you wouldn't want to return anything - you'd use a sub:

Public Sub AddTeamAndPlayer(TeamName As String, PlayerName As String)
    AddTeam(TeamName).AddPlayer PlayerName
End Sub

 

[mahmed1]

Hi Kyle

firstly i want to thank you again

you truly are a MVP and i would recommend again that you are worthy of that title

is there any chance you could based on my example give an example where i could use this interface structure as i will have both a manager and agent who are employees but have same properties?

many thanks

 

[Kyle123]

Post a new thread, it's not really related to this and this one is getting a bit long