populating data show error in textboxes number on userform

[Hasson]

Hi
I have about 24 textboxes when I select the item from listbox should populate from textbox 1 to textbox24 , but it populates staring from textbox 3,
the textbox1,2 is empty !!! what's the mistake?

Private Sub ListBox1_Click()
For i = 0 To ListBox1.ListCount
    If ListBox1.Selected(i) = True Then
        For j = 1 To 24
        Controls("TextBox" & j).Text = Cells(ListBox1.List(i, 1), j)
        Next j
    End If
Next i
End Sub

 

[NdNoviceHlp]

Hi Hasson. For "i", the Listbox1 does have List item 0 but not List item Listbox1.ListCount. That doesn't resolve your issue which I suspect is related to your use of "Cells". Try qualifying it with a sheet name ie. Sheets("Sheet1").Cells etc. You may also want to qualify your controls ie. Userform1.Listbox1; Userform1.Controls etc. U also have to have all the listbox items selected before the textboxes can be filled? Also, U check your textbox names. HTH. Dave

 

[Hasson]

thanks but this doesn't solve the problem .

 

[Hasson]

any solutin for fix this problem ?

 

[dmt32]

any solutin for fix this problem ?

untested but try following update to your code & see if resolves the issue

Private Sub ListBox1_Click()
    Dim i           As Long
  
    With Me.ListBox1
        For i = 0 To .ListCount - 1
            If .Selected(i) = True Then
                For j = 1 To .ColumnCount
                    Me.Controls("TextBox" & j).Text = .List(i, j - 1)
                Next j
            End If
        Next i
    End With
  
End Sub

Dave

 

[Hasson]

thanks Dave !
unfortunately just fill textbox1 and the others become empty .

 

[dmt32]

curious - you probably have something else going on.

Publishing all the userforms codes would be helpful to forum & copy of worksheet with dummy data using MrExcel Addin xl2BB

Dave

 

[Hasson]

this is the whole codes

Private Sub ListBox1_Click()
For i = 0 To ListBox1.ListCount
    If ListBox1.Selected(i) = True Then
        For j = 1 To 24
        Controls("TextBox" & j).Text = Cells(ListBox1.List(i, 1), j)
        Next j
    End If
Next i
End Sub

Private Sub TextBox25_Change()
ListBox1.Clear

    For i = 1 To 24
            Controls("TextBox" & i).Text = ""
    Next i

    If TextBox25 = "" Then Exit Sub
    Sheets("file1").Activate

    ss = Sheets("file1").Cells(Rows.Count, 6).End(xlUp).Row
     k = 0
     
     
For Each C In Range("f10:f" & ss)
    If C Like TextBox25.Value & "*" Then
        ListBox1.AddItem
        ListBox1.List(k, 0) = Cells(C.Row, 6).Value
        ListBox1.List(k, 3) = C.Row
        k = k + 1
    End If
Next C


End Sub

Private Sub UserForm_Activate()
TextBox25.SetFocus
For i = 10 To Sheets("file1").Cells(Rows.Count, 6).End(xlUp).Row
ListBox1.AddItem
 ListBox1.List(i - 10, 0) = Cells(i, 6).Value
  ListBox1.List(i - 10, 1) = i
      Next i
End Sub

when populate data strat from column C from row 10 to column Z

 

[dmt32]

when populate data strat from column C from row 10 to column Z

in that case try following

Private Sub ListBox1_Click()
    Dim i As Long, j As Long
   
    With Me.ListBox1
        For i = 0 To .ListCount - 1
            If .Selected(i) = True Then
                For j = 1 To 24
                    Me.Controls("TextBox" & j).Text = Cells(i + 10, j + 2).Text
                Next j
            End If
        Next i
    End With
   
End Sub

range is unqualified & assumes sheet with data is the activesheet

Dave

 

[Hasson]

every thing is great !
much appracite for your help