run time error fix

[HonestMan]

Hi guys

I am using the below code to save the workbook to the desktop by click of a button. When the button is clicked, it saves it to the desktop. After saving, a message box appears asking 'do you want to save the file'. If I click 'yes' or 'no' it works fine. But after it is saved to the desktop, if i reopen and click on save to desktop button a message box appears again asking 'do you want to save the file'. If I click 'yes' the code works fine but if I click 'no' I get a run time error. can any please tell me how to fix this. Thanks in advance

Private Sub CommandButton1_Click()
If Range("D5") = "" Then
MsgBox "Please enter yyy before saving the file."
Else
ActiveWorkbook.SaveAs Filename:=CreateObject("WScript.Shell").SpecialFolders("Desktop") & "\" & Range("D5")
Range("x50").Value = "xxx"
ActiveWindow.Close
End If
End Sub

 

[RoryA]

Try this:

Private Sub CommandButton1_Click()
If Range("D5") = "" Then
MsgBox "Please enter yyy before saving the file."
Else
Range("x50").Value = "xxx"
ActiveWorkbook.SaveAs Filename:=CreateObject("WScript.Shell").SpecialFolders("Desktop") & "\" & Range("D5")
ActiveWorkbook.Close SaveChanges:=False
End If
End Sub

 

[HonestMan]

Thanks Rory. Tried but not working

 

[klarowe]

It seems to be working for me. But a quick question... is there a reason you have it saving regardless of whether "Yes" or "No" or even "Cancel" is selected?

 

[HonestMan]

actually I dont want it to save when clicking no or cancel but all I want is discard the changes made and dont want it to show the run time error thats it

 

[HonestMan]

it is run time error 1004 and found how to resolve from below page

http://support.microsoft.com/kb/210684

But not able to come up with the code that suits my code, macro newbie!

Can someone please help with code that suits my code?