running sub-procedure from button malfunctions but running it from vba editor works fine?

[binaya shahi]

running sub-procedure from button malfunctions but running it from vba editor works fine?

this problem started when i protected all worksheet.
I wrote the following code to unprotect all the sheets at the beginning of sub-procedure
and again protect all worksheet in the end of sub-procedure.

Please help!

sub name()
Dim ws As Worksheet
For Each ws In Worksheets
ws.Unprotect

code

Dim ws As Worksheet
For Each ws In Worksheets
ws.Unprotect

end sub

 

[steve the fish]

That couldnt work from a button or from the vba editor. Its missing a Next for both of the For statements. You also need protect not unprotect at the bottom.

For Each ws In ThisWorkbook.Worksheets
        ws.Unprotect
Next
'code
For Each ws In ThisWorkbook.Worksheets
        ws.Protect
Next

 

[binaya shahi]

That couldnt work from a button or from the vba editor. Its missing a Next for both of the For statements. You also need protect not unprotect at the bottom.

For Each ws In ThisWorkbook.Worksheets
        ws.Unprotect
Next
'code
For Each ws In ThisWorkbook.Worksheets
        ws.Protect
Next

actually there is Next in the code. I made mistake copying my code to the forum.
so missing Next is not the issue.

"This subprocedure working from vba editor but not working from the the button i created in worksheet" is the issue. what might be the reason?

 

[binaya shahi]

That couldnt work from a button or from the vba editor. Its missing a Next for both of the For statements. You also need protect not unprotect at the bottom.

For Each ws In ThisWorkbook.Worksheets
        ws.Unprotect
Next
'code
For Each ws In ThisWorkbook.Worksheets
        ws.Protect
Next

actually there is Next in the code and ws.unprotect at the bottom of the code. So that is not the issue. its just my copypaste mistake.
"This subprocedure working from vba editor but not working from the the button i created in worksheet" is the issue. what might be the reason?
actually if i just remove ws.protect from bottom, this code works fine both from vba editor and excel button.