Save workbook in 2 places macro

[ttratl]

Hello,

Not sure what's going on with this code...
It was working fine for months, but since I reinstalled Win7 and all my programs, it's gone wrong.
I've altered the locations of where to save the files, as those had changed, but the macro now opens a password dialogue box for a previous file version.

I've been messing around with this for an hour, so I think this is the version that was working previously.
any ideas?

Sub SaveAs()
'
' SaveAs Macro
         
     ActiveWorkbook.SaveAs FileName:= _
       "E:\Ians documents\_Excel\Cashbook\Cashbook 8 as at " & Format(Date, "dd mm yy") & Format(Time, " hhmm") & ".xlsm", _
      Password:="xxxxxx", WriteResPassword:="", ReadOnlyRecommended:=False, CreateBackup:=False
        
     ActiveWorkbook.SaveCopyAs FileName:= _
       "C:\Users\Ian\Desktop\" & "Cashbook 8 as at " & Format(Now(), "dd mm yy") & Format(Time, " hhmm") & ".xlsm"
   
      
End Sub

 

[VoG]

Try

Sub SaveAs()
'
' SaveAs Macro
         
     ActiveWorkbook.SaveAs Filename:= _
       "E:\Ians documents\_Excel\Cashbook\Cashbook 8 as at " & Format(Date, "dd mm yy") & Format(Time, " hhmm") & ".xlsm", _
      FileFormat:=52, Password:="xxxxxx", WriteResPassword:="", ReadOnlyRecommended:=False, CreateBackup:=False
        
     ActiveWorkbook.SaveCopyAs Filename:= _
       "C:\Users\Ian\Desktop\" & "Cashbook 8 as at " & Format(Now(), "dd mm yy") & Format(Time, " hhmm") & ".xlsm"
   
      
End Sub

 

[ttratl]

Thanks Vog.

I appear to have more serious issues, in that i cannot fire this macro from a QAT button (Excel 2010), which may mean my original macro was ok anyway.
I've ended up with this code:

Sub SaveInTwoPlaces()

    ChDir "E:\Ians documents\_Excel\Cashbook"
    ActiveWorkbook.SaveAs FileName:= _
        "E:\Ians documents\_Excel\Cashbook\Cashbook 8 as at " & Format(Date, "dd mm yy") & Format(Time, " hhmm") & ".xlsm", FileFormat _
        :=xlOpenXMLWorkbookMacroEnabled, CreateBackup:=False

    ChDir "C:\Users\Ian\Desktop"
    ActiveWorkbook.SaveAs FileName:= _
        "C:\Users\Ian\Desktop\Cashbook 8 as at " & Format(Date, "dd mm yy") & Format(Time, " hhmm") & ".xlsm", FileFormat:= _
        xlOpenXMLWorkbookMacroEnabled, CreateBackup:=False

End Sub

Which works fine, but still won't fire from a QAT button. I think this is something to look at on another day. There seems to be some info on a few Google searches to look at.