Some Trouble With If Then Else Statement

[Do Vo Anh]

I have some trouble when i used this code to run.. Can i someone give me some ideas to improve it? Thanks for your attention.
Sub Code()
Dim i As Integer
Dim a As Double
Dim Atan As Double
i = 43
If Cells(i, 1).Value = 0 Then
Cells(i, 6).Value = 0
Else
Do While Cells(i, 1).Value <> vbNullString
Cells(i, 6).Value = (Atn(-0.36 / (Cells(i, 1).Value * (-1.375))) / 2) * (180 / 3.141592654)
i = i + 1
Loop
End If
End Sub

 

[RudiS]

What trouble are you getting?
Please elaborate.

 

[Do Vo Anh]

The code. It's not show the value of formula next to Else function

 

[RudiS]

Do you mean the zero is not being put in the E column?
When I run the code, all the values; the zero and the ATN formulas get written down the F column.

 

[Do Vo Anh]

ADVERTISEMENT

Even when the code had error " division by zero" you didnt see the value in a43 is 0.

 

[RudiS]

I'm sorry. I still don't understand what your issue is?

When I recreated your sheet in my own sample file and I ran your code, cell F43 was a zero and the other values down the F column calculated fine based on your formula. So I'm not sure why you are refering to the #DIV/0! error as this is not the output of the macro?

 

[RoryA]

If your first value is 0 you never increment the row variable 'i' so you only process the first row. I think your If... Then block should be inside the Do... While loop.

 

[RudiS]

I think you hit the nail on the head there Rory.... (stupidme!!)

Taking Rory's keen observation, this code should work.

Sub Code()
Dim i As Integer
Dim a As Double
Dim Atan As Double
    i = 43
    Do While Cells(i, 1).Value <> vbNullString
        If Cells(i, 1).Value = 0 Then
            Cells(i, 6).Value = 0
        Else
            Cells(i, 6).Value = (Atn(-0.36 / (Cells(i, 1).Value * (-1.375))) / 2) * (180 / 3.141592654)
        End If
        i = i + 1
    Loop
End Sub