SQL Statement

[fodzilla]

Hi Guys,

Been working on something for a while and now have an issue with something in the below statement.

Anyone able to help out?

strSQL = "INSERT INTO tbl_TM1_Volumes ( TM1UniqueKey, Site, Date, Time_Band, Number_of_Exits ) " & _
" VALUES (" & _
"" & Sheet1.Cells(iRow, 1) & ", " & _
"" & Sheet1.Cells(iRow, 2) & ", " & _
"" & Sheet1.Cells(iRow, 3) & ", " & _
"" & Sheet1.Cells(iRow, 4) & ", " & _
"" & Sheet1.Cells(iRow, 5) & " )"

Looks fine to me but still erroring.

 

[fodzilla]

Here is my full code:

Private Sub Workbook_open()


Dim strSQL As String
Dim iRow As Long

Call ConnectDatabase

For iRow = 2 To 150


' strSQL = "INSERT INTO tbl_TM1_Volumes ( Site ) " & _
' " VALUES (" & _
' "" & Sheet1.Cells(iRow, 2) & ") "

strSQL = "INSERT INTO tbl_TM1_Volumes ( TM1UniqueKey, Site, Date, Time_Band, Number_of_Exits ) " & _
" VALUES (" & _
"" & Sheet1.Cells(iRow, 1) & ", " & _
"" & Sheet1.Cells(iRow, 2) & ", " & _
"" & Sheet1.Cells(iRow, 3) & ", " & _
"" & Sheet1.Cells(iRow, 4) & ", " & _
"" & Sheet1.Cells(iRow, 5) & " )"


' MsgBox strSQL
DBCONT.Execute strSQL



Next iRow


Call CloseDatabase
End Sub

 

[Fazza]

Hi

Please post the specifics of the error. Please post the sample data that is associated with it.

How are the dates stored in the worksheet? In the database. Which fields are text?

Please post the SQL as it shows in the msgbox (or just debug.print strSQL).

Field name Date could be a problem, btw. Maybe better to either change it to [Date] or re-name it, or give it an explicit table prefix.

Are there any nulls in the data?

For interest, a thread from not too long ago : http://www.mrexcel.com/forum/excel-...ations-export-data-ms-access-table-print.html

regards

 

[Fazza]

Are the fields and data types consistent between the database and Excel? To resolve these sort of questions specific info needs to be provided. cheers