Trying to fill a combo box value to a cell in vba code

[Darren Smith]

I have created this code but it says error 438
Any ideas why??

Sub BodyType()

Dim cmb As ComboBox
Dim wsDest As Worksheet
Dim i As Long, Range As Long

Set wsDest = ThisWorkbook.Worksheets("Job Card Master")
Set cmb = Body_And_Vehicle_Type_Form.Body_Type

For i = 0 To cmb.ListCount - 1

If cmb.Selected(i) Then

  wsDest.Range("E4") = cmb.List(i, 0)
  
    End If
    
  Next i

End Sub

 

[My Aswer Is This]

You do not really need to loop through the values in the Combobox.

I use something like this:
Script runs when you select value in Combobox

Private Sub ComboBox1_Change()
'Modified  4/15/2021  9:25:16 AM  EDT
Worksheets("Job Card Master").Range("E4").Value = ComboBox1.Value
End Sub

 

[mart37]

Do want one value?

If cmb.ListIndex <> -1 Then wsDest.Range("E4") = cmb.Value

 

[Darren Smith]

Thanks very much works fine