VBA Bug

[VbaHell]

Hello All

Could someone help on this please.
The code below is in the "Thisworkbook" module and when you click on save the code saves the sheet to the correct path and names the file with data from B13 and G13.
This code keeps bugging out on line "Me.SaveAs Filename:=Fname, FileFormat:=52", any idea's on how to fix this.
I am using excel 2007



Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
Dim Fname As String
Cancel = True
Application.EnableEvents = False
Fname = "S:\Branch Data\test office\testing\CAT no\" & Sheets("Sheet1").Range("B13").Value & " " & Format(Sheets("Sheet1").Range("G13").Value, "dd-mm-yyyy") & ".xlsm"
MsgBox Fname
Me.SaveAs Filename:=Fname, FileFormat:=52
Application.EnableEvents = True
End Sub

 

[venkat1926]

does this path exist?

S:\Branch Data\test office\testing\CAT no\

does sheet1 B13 have some data?

check theses

 

[Norie]

Try not specifying the FileFormat in the SaveAs.

 

[p45cal]

You have MsgBox Fname, so when it goes wrong next:
(a) tell us the error message
(b) in the Immediate Pane of the VBE (Ctrl+G if you can't see it) type:
?Fname
and press Enter, then paste the results here - it could be the filename has some illegal characters in it.

 

[GTO]

Maybe just my blind eyes, but in addition to venkat's, Norie's, and Pascal's observations - I do not see where you are preventing recurse. Not tested, but I am windering if the "bugging out" might be a continuous loop. Save/BeforeSave/Cancel/BeforeSave calls a Save/..........

 

[VbaHell]

Thank you to all for your comments, It turn out that the path was not correct
Many thanks to all